Currently when the current line should be removed from the display
kdb_read() uses memset() to fill a temporary buffer with spaces.
This can be trivially implemented using a format string. Make it so!

Note that this also simplifies the code by making the tab-completion
code the only code that uses tmpbuffer (and therefore makes reviewing
to ensure tmpbuffer can never overflow much easier).

Signed-off-by: Daniel Thompson <daniel.thomp...@linaro.org>
---
 kernel/debug/kdb/kdb_io.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index 08a86a329eb64..94a638a9d52fa 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -295,11 +295,9 @@ static char *kdb_read(char *buffer, size_t bufsize)
                break;
        case 14: /* Down */
        case 16: /* Up */
-               memset(tmpbuffer, ' ',
-                      strlen(kdb_prompt_str) + (lastchar-buffer));
-               *(tmpbuffer+strlen(kdb_prompt_str) +
-                 (lastchar-buffer)) = '\0';
-               kdb_printf("\r%s\r", tmpbuffer);
+               kdb_printf("\r%*c\r",
+                          (int)(strlen(kdb_prompt_str) + (lastchar - buffer)),
+                          ' ');
                *lastchar = (char)key;
                *(lastchar+1) = '\0';
                return lastchar;

-- 
2.43.0



_______________________________________________
Kgdb-bugreport mailing list
Kgdb-bugreport@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport

Reply via email to