The docs say you should use kstrtouint() instead of simple_strtoul(), so do so. This nicely simplfies the code a little.
Signed-off-by: Douglas Anderson <diand...@chromium.org> --- kernel/debug/kdb/kdb_main.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index c064ff093670..6dcbf4ea4bcd 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -1612,11 +1612,8 @@ static int kdb_md(int argc, const char **argv) bytesperword = (int)(argv[0][2] - '0'); if (!argv[0][3]) valid = true; - else if (argv[0][3] == 'c' && argv[0][4]) { - char *p; - repeat = simple_strtoul(argv[0] + 4, &p, 10); - valid = !*p; - } + else if (argv[0][3] == 'c' && argv[0][4]) + valid = kstrtouint(argv[0] + 4, 10, &repeat) == 0; } else if (strcmp(argv[0], "md") == 0) valid = true; else if (strcmp(argv[0], "mds") == 0) -- 2.45.2.627.g7a2c4fd464-goog _______________________________________________ Kgdb-bugreport mailing list Kgdb-bugreport@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport