Hi, On Sun, Jan 26, 2025 at 12:22 AM Daniel Thompson <dani...@kernel.org> wrote: > > On Sat, Jan 25, 2025 at 09:13:15PM +0000, Matthew Wilcox wrote: > > This is a bad patch. It looks like you should have used > > memcpy_from_page(). > > Thanks for the feedback. > > Just to check, in this case does "bad patch" mean functionally > incorrect or simply that kdb is open coding something for which > better helpers exist. > > To be clear, we should fix either way, but I wanted to check > the impact.
FWIW, it seems hard to believe it would have any actual impact. The current definition of memcpy_from_page() that I see is literally doing the exact same thing as we're doing now in kdb. I agree with Daniel that someone should submit a patch to improve it to use memcpy_from_page() to save 2 lines of code, but I'm not so sure I'd call the current code "bad". -Doug _______________________________________________ Kgdb-bugreport mailing list Kgdb-bugreport@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
