On Wed, Mar 19, 2025 at 9:35 AM Thorsten Blum <thorsten.b...@linux.dev> wrote:
>
> If the destination buffer has a fixed length, strscpy() automatically
> determines the size of the destination buffer using sizeof() if the
> argument is omitted. This makes the explicit sizeof() unnecessary.
>
> Furthermore, CMD_BUFLEN is equal to sizeof(kdb_prompt_str) and can also
> be removed. Remove them to shorten and simplify the code.
>
> No functional changes intended.
>
> Signed-off-by: Thorsten Blum <thorsten.b...@linux.dev>
> ---
> kernel/debug/kdb/kdb_io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
> index 6a77f1c779c4..9b11b10b120c 100644
> --- a/kernel/debug/kdb/kdb_io.c
> +++ b/kernel/debug/kdb/kdb_io.c
> @@ -334,7 +334,7 @@ static char *kdb_read(char *buffer, size_t bufsize)
> *cp = '\0';
> p_tmp = strrchr(buffer, ' ');
> p_tmp = (p_tmp ? p_tmp + 1 : buffer);
> - strscpy(tmpbuffer, p_tmp, sizeof(tmpbuffer));
> + strscpy(tmpbuffer, p_tmp);
> *cp = tmp;
>
> len = strlen(tmpbuffer);
> @@ -452,7 +452,7 @@ static char *kdb_read(char *buffer, size_t bufsize)
> char *kdb_getstr(char *buffer, size_t bufsize, const char *prompt)
> {
> if (prompt && kdb_prompt_str != prompt)
> - strscpy(kdb_prompt_str, prompt, CMD_BUFLEN);
> + strscpy(kdb_prompt_str, prompt);
> kdb_printf("%s", kdb_prompt_str);
> kdb_nextline = 1; /* Prompt and input resets line number */
> return kdb_read(buffer, bufsize);
This matches the pattern of replacements I've done in the past, all looks good.
Reviewed-by: Justin Stitt <justinst...@google.com>
Justin
_______________________________________________
Kgdb-bugreport mailing list
Kgdb-bugreport@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
