On Mon 2025-09-15 08:20:30, Marcos Paulo de Souza wrote: > The helper will be used on KDB code in the next commits. > > Reviewed-by: Petr Mladek <[email protected]> > Signed-off-by: Marcos Paulo de Souza <[email protected]>
Nit :-) The ordering of the tags is important. It defines the timeline of the related actions. The above ordering might be understood as that Petr reviewed an older version of patch. But it was later modified by Marcos. The expected ordering is: Signed-off-by: Marcos Paulo de Souza <[email protected]> Reviewed-by: Petr Mladek <[email protected]> It means that Macros developed a patch and Petr reviewed it. The patch was not longer modified. Note the Reviewed-by tag might be preserved even when Marcos later did some cosmetic changes, e.g. fixed a typo, formatting, or rebased. Best Regards, Petr PS: There is no need to send v5 just because of this. I could fix it when committing the patch... _______________________________________________ Kgdb-bugreport mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
