On Fri 2025-11-21 15:50:33, Marcos Paulo de Souza wrote: > The original code tried to find a console that has CON_BOOT _or_ > CON_ENABLED flag set. The flag CON_ENABLED is set to all registered > consoles, so in this case this check is always true, even for the > CON_BOOT consoles. > > The initial intent of the kgdboc_earlycon_init was to get a console > early (CON_BOOT) or later on in the process (CON_ENABLED). The > code was using for_each_console macro, meaning that all console structs > were previously registered on the printk() machinery. At this point, > any console found on for_each_console is safe for kgdboc_earlycon_init > to use. > > Dropping the check makes the code cleaner, and avoids further confusion > by future readers of the code. > > Signed-off-by: Marcos Paulo de Souza <[email protected]>
I agree that the check is superfluous and can be removed: Reviewed-by: Petr Mladek <[email protected]> Best Regards, Petr _______________________________________________ Kgdb-bugreport mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
