On 07/09/2010 08:57 AM, Lorenzo Marcantonio wrote: > On Fri, 9 Jul 2010, Dick Hollenbeck wrote: > >> 1) If moving away from int for aUnits, must we go to bool? Can we at >> least go to a new enum rather than a bool? Why burn the bridge to being >> able to support other units in the future? (There is no cost to >> preserving the bridge.) > > Agreed, the right type should be an enum (someone could argue for class > singletons, but I am personally *against* OO). I used a bool since *some* > function used an int and *some* only the bool. In fact the CENTIMETRE > unit (used once, and only for the plot pen speed which isn't either used > in kicad's unit) was treated more or less inconsistently. > >> parameter. I prefer aUnits. > > What does the 'a' stand for, BTW? and why units since it singular (THE > unit, not some of these...)
a = argument, plus it can lead to clever doxygen comments that read well if you utilize this in the doxygen comments. We often use the phrase, "engineering units" in technical circles. It always seems to be plural. Agreed it's bad English, but most of C++ is bad English, no terrible. I don't care about the s. > >> 3) Your single line C comments should really be C++ comments and have >> blank lines above them. > > I'm more a C/Lisp programmer than a C++ one :P > >> 4) Your bracket placement is not compatible with established style. >> >> 5) There should be no spaces after while, for, or if. >> >> 6) There should be a space after most any (. > > Uhmm the uncrustify config is still valid? (as a personal note > I have /never/ seen an indentation convention like that you use... > expecially for the parenthesis). Yes you have, you have been looking at Kicad for years now. And we thank you for it. > > Working on the issues. > Thanks. Hopefully others will voice any objections they may have, and if none come up, I would be happy to commit a fixed patch. Dick _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
