Getting "Hunk #1 succeeded at 145 (offset 4 lines)" when applying patch.
A part from the above, everything is working great.. thanks for your awesome contribution. Fabio On 01/29/2011 05:55 AM, Phinitnan Chanasabaeng wrote: > It turned out that, The wxGLCanvas is initialized incorrectly in > kicad. I've fixed the initialization and added some protection code. > The patch is attached, please review. > > Tony > > On Sat, Jan 29, 2011 at 10:15 AM, Phinitnan Chanasabaeng > <[email protected] <mailto:[email protected]>> wrote: > > I forgot to mention one thing, the explicit declaration of > wxGLContext is suggested (required?) by wxWidgets since 2.7.x but > kicad do this in 2.9.x++. > So, all the lines with #if wxCHECK_VERSION( 2, 9, 0 ) macro should > be changed to #if wxCHECK_VERSION( 2, 7, 0 ). I don't know if > there is any paticular reason for kicad to do so. > > Fabio, > > Yes, I also see the layer problem. Just woke up and will try to > fix it today :) > > Charras, > > As far as I know, this bug normally occurs on some certain > computers. Most of them use anything but Nvidia. I'm now using > Intel graphic and affected by this bug. What is you hardware being > used? > > Tony > > > On Sat, Jan 29, 2011 at 3:47 AM, jean-pierre charras > <[email protected] <mailto:[email protected]>> wrote: > > Le 28/01/2011 19:08, Phinitnan Chanasabaeng a écrit : > > Have a look the 3d-view source, PCBNEW will crash after > calling SwapBuffers (3d_draw.cpp:101). Comment out this > call stop the crash. > What confuse me is, 3d view should have not drawn anything > but it did. Without SwapBuffers, everything works as it > should. > I'm now investigating and trying to find the cause. Can > someone confirm this and please leave your suggestion. > > Tony > > > Test under XP, 3d view does not drawn anything! > > -- > Jean-Pierre CHARRAS > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > <https://launchpad.net/%7Ekicad-developers> > Post to : [email protected] > <mailto:[email protected]> > Unsubscribe : https://launchpad.net/~kicad-developers > <https://launchpad.net/%7Ekicad-developers> > More help : https://help.launchpad.net/ListHelp > > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
