On 9/9/2011 4:11 AM, fabrizio wrote: > Dick, > good morning. > > The patch I submitted does not contain the re-built PNGs after some > .svg were modified by my, I thought this is what I was supposed to do > and that is why it is necessary to rebuild the PNGs. If you prefer in > attachment you can find the same patch for which it is not necessary > to rebuild the PNG. The patch is however 6.5MB. This I immagine is the > consecuence of considering PNGs as part of the code. > > I am changing the .svg so I guess that makes me a :PNG maintainer" > > I hope this will help to clear up the misunderstand. If not, please > advise what to do. > > cheers > Fabrizio
Fabrizio, I rebuilt all the PNGs and included the generated cpp files when I committed your last patch. All of the PNGs now have a transparent background which makes them look much better in the tool bars. Thanks again both you and Dick for for efforts on this. Wayne > > > On Fri, Sep 9, 2011 at 7:10 AM, Dick Hollenbeck <[email protected]> wrote: >> On 09/08/2011 11:43 AM, fabrizio wrote: >>> Hello, >>> >>> The following patch implement the following: >>> - fix icon margins in KiCad program icons >>> - remove metal background in all icons >>> - fix some icons here and there (save button is now the standard one) >>> - fix the icons "pcb calculator" and "bitmap2component" in KiCad >>> - fixed button image.svg >>> - fix a building problem in the icon CMakeLists file >>> - some other minor stuff >>> >>> after the patch is applied all icons need to be rebuild with: >>> cmake ../ -DKICAD_TESTING_VERSION=ON -DCMAKE_BUILD_TYPE=Debug >>> -DMAINTAIN_PNGS=ON >> >> Well this should not technically be true for the following reason: >> >> The bitmaps_png/CMakeLists.txt file is designed to allow folks to build Kicad >> and NOT be PNG maintainers. This means the PNG images are already built in >> our >> source tree as *.cpp files. >> >> This means your patch is broken if you think people should be building the >> cpp_26/*.cpp files. >> >> These files are part of the repo, and do not have to be rebuilt, ever, unless >> you want to be a maintainer. >> So what is wrong with the patch? >> >> 1) it did not include the pre-built *.cpp files, according to your own words. >> >> Dick >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
