On Wed, May 09, 2012 at 07:42:04PM -0400, Wayne Stambaugh wrote: > 1) It is fine for folks to test but there are too many changes at least > for me to review and commit at one time. For committing purposes I > would prefer this be broken into four separate patches. One each for > the EDA_COLOR_T, EDA_DRAW_MODE_T, PCB_LAYER_MASK, and the Eeshema > m_Layer removal. It's not necessarily the size of the patch. It's the > number of things it changes that makes me take pause.
I agree, 500KB of patch are a lot XD. Now I have to think a way to split it... > 2) Please convert tabs to 4 spaces. OK, :untab will do > 3) Please remove trailing white space. > 4) It appears you are using Windows as your development platform because > the new files you added have ^M as the line ending. Your editor should > be able to strip these out and configured not to use them. Nope, they come back dos formatted from bzr... isn't there an option like svn:eol-style to get them right? I have trouble with them, too! > I'm extremely busy right now so I don't have any free time to test this. No problem, it's only a cleanup refactoring thing anyway! -- Lorenzo Marcantonio Logos Srl _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
