Hi, it warns because it is not clear whether (a) you really mean the assignment (and want to check if the result is zero) or (b) you just forgot one “=“ and you meant “ip == s1…”. The additional brackets are proposed in the compiler warning to silence the warning in case of (a).
Beside a lot of warnings I have switched off via compile switch both build for me. On OSX, I have: Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn) Regards, Bernhard On 03.06.2014, at 00:32, Tomasz Wlostowski <[email protected]> wrote: > On 02.06.2014 19:52, Bernhard Stegmaier wrote: >> Hi, >> >> building with clang (at least on OSX) and -Wall is really noisy so that >> you can hardly see what’s going wrong. >> So, I decided to fix the warnings… attached are 3 patches I prepared >> (against rev. 4911): >> >> *** clang-warnings-1.diff: >> Everything that probably should be fixed:\ > > Hi Bernhard, > > - if( ip = s1.Intersect( s_next ) ) > + if( (ip = s1.Intersect( s_next )) ) > > What upsets clang in the first line? I'm asking because I'm unable to get > Kicad to build with clang on Linux (wx 3.0) due to compilation errors in wx... > > Tom
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
