Someone in #kicad already told me about the formatting issues, I hadn't noticed those before. I'll work in space mode for future development.
From quick testing your patch is functionally identical to my proposed one. On Wed, 2014-07-23 at 09:32 -0500, Dick Hollenbeck wrote: > On 07/22/2014 06:43 PM, Andrew Zonenberg wrote: > > Proposed fix attached. > > > > With this patch, vias are displayed if > > a) via display is turned on, and > > b) at least one of the layers the via crosses is displayed. > > Hi Andrew, > > Thanks for the idea and the patch. The patch has tabs in it and trailing > whitespace. > So its best not to fight your text editor in this way. The human will always > forget. > Simply change your editor's settings instead. > > > I'd also like not expose the "for loops", but rather use VIA::GetLayerSet() > which has > capabilities for caching in the future and hides information in general. > > > Please try the attached patch instead, and notice any formatting differences. > > > Dick > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp -- Andrew Zonenberg PhD student, security group Computer Science Department Rensselaer Polytechnic Institute http://colossus.cs.rpi.edu/~azonenberg/
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
