These look good to me. Adam Wolf Cofounder and Engineer W&L
On Mon, Dec 8, 2014 at 4:27 AM, Johannes Maibaum <[email protected]> wrote: > Dear KiCad Developers, > > I have attached a patch that changes a few small things to improve some > build helper scripts for use on Mac OSX: > > 1) Make patches/wxwidgets-3.0.2_macosx_yosemite.patch usable: There were > complaints here before that the patch does not work because it is a > "metapatch" that tries to patch another patch (which is not in the tree and > therefore fails). With this change, it becomes a normal patch again, that > can be applied to the wxWidgets source tree as described in > Documentation/compiling/mac-osx.txt. > > 2) Make scripts/library-repos-install.sh compatible with OSX: This > involves checking for the correct option to enable extended regular > expressions in sed during detect_pretty_repos, as the script uses "-r", > which is only available in GNU sed. The sed shipped with Mac OSX is an > older BSD descendant sed which needs "-E". This change has been tested to > work on Mac OSX 10.10.1 and on an up-to-date Arch Linux. I also changed the > error message during --install-prerequisites to inform users without > apt-get or yum which programs need to be installed to use the script. > > 3) Add the execute flag to scripts/osx_build_wx.sh: At the moment, after > fetching the source with bzr, one has to chmod the file by hand. This > change change ensures consistency between the script and the build docs for > OSX, which assumes the script to be executable. > > > And, I really want to say thank you to all the people involved in the > development of KiCad. You are doing an amazing job! To an electronics > hobbyist like me, having a free EDA solution at one's disposal is simply > invaluable. Perhaps, my patch can improve the experience for people on Mac > OSX still a little more. > > > Best, > > Johannes > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
