If the discussion gets too long, I should also say "I like this patch as it is, too" so this should get committed anyway, regardless of changing a default path on OS X. A long discussion about paths shouldn't hold this patch up.
Adam Wolf On Feb 22, 2015 12:25 PM, "Adam Wolf" <[email protected]> wrote: > Agreed 100%. > On Feb 22, 2015 11:03 AM, "Bernhard Stegmaier" <[email protected]> > wrote: > >> Hi Adam, >> >> this would be no problem… currently packages3d is put under modules for >> all OSes, I didn’t change anything with that. >> It’s only the base path which was broken… >> >> Of course, it would be also no problem just to change packages3d location >> for OS X. >> >> If we agree on something, I can make the change… >> I think we should agree/check before if it should be done only for OS X >> or for all OS. >> >> >> Regards, >> Bernhard >> >> On 22 Feb 2015, at 17:58, Adam Wolf <[email protected]> >> wrote: >> >> Bernhard, >> >> This looks good except the Mac dmgs work nicer if we put packages3d >> outside of modules, instead of inside of it. >> >> This is due to how drag-and-drop copying works on OS X. I have modules/ >> inside of the extras dmg, but packages3d inside of the main dmg. If we >> keep packages3d inside of modules, I'll have to include it in both dmgs, >> rather than just in main. >> >> I think Cirilo actually proposed this for all platforms a little bit ago. >> >> Adam Wolf >> Cofounder and Engineer >> W&L >> >> On Sun, Feb 22, 2015 at 10:23 AM, Bernhard Stegmaier < >> [email protected]> wrote: >> >>> Hi, >>> >>> default paths for KISYSMOD/KISYS3DMOD are currently broken on OS X (set >>> to same as for other OSes). >>> >>> Attached patch >>> * OS X: Fixes default KISYSMOD/KISYS3DMOD (#ifdef typo) >>> * OS X: Removes setting KIGITHUB from kicad/pcbnew Info.plist in favor >>> of hardcoded default setting >>> * Removes now unneeded Set3DShapesDefaultPath() and other small things >>> >>> >>> >>> >>> Removing Set3DShapesDefaultPath() seems to be OK for OS X and I guess it >>> is also no longer needed for other OSes, but please double-check that. >>> >>> Note: >>> I intentionally did not use __WXMAC__ but __APPLE__ in config.h as >>> __WXMAC__ possibly might not yet be defined (by some wxWidgets include) >>> when including config.h (although it seems as if cmake compiles all files >>> using -D__WXMAC__, so it should be defined everywhere). >>> >>> >>> Regards, >>> Bernhard >>> >>> PS: >>> Just in case, maybe it saves somebody some time… it took me almost a day >>> to find out that my code changes in fact did work, but the old/wrong values >>> have been written to KiCad preferences and have been taken from there >>> overriding the new hardcoded default values... >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >>> >> >>
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
