Hi, this is a bunch of low priority patches, because these do not change anything really.
- #1-3 are straightforward and probably make sense to apply - #4 could make sense, but is not required on currently supported platforms because these happen to do the right thing anyway. - #5 is massive, and synchronizes the entire codebase to explicitly virtual functions. It might be a bit boring to read though. Simon Richter (5): Indentation cleanup Implement GetClass() throughout the project Make Show() dependent on DEBUG preprocessor symbol Use platform safe storage for pin numbers Add virtual keyword to implicitly virtual functions 3d-viewer/3d_material.h | 10 +- 3d-viewer/3d_struct.h | 12 ++- 3d-viewer/3d_viewer.h | 4 +- 3d-viewer/dialogs/dialog_3D_view_option.cpp | 6 +- 3d-viewer/modelparsers.h | 8 +- bitmap2component/bitmap2cmp_gui.cpp | 22 ++-- common/confirm.cpp | 6 +- common/dialogs/dialog_image_editor.h | 19 ++-- common/dialogs/dialog_page_settings.h | 32 +++--- common/single_top.cpp | 12 +-- cvpcb/class_DisplayFootprintsFrame.h | 18 ++-- cvpcb/cvpcb.cpp | 8 +- cvpcb/cvpcb_mainframe.h | 6 +- cvpcb/cvstruct.h | 6 +- cvpcb/dialogs/dialog_config_equfiles.h | 16 +-- cvpcb/dialogs/dialog_display_options.h | 8 +- cvpcb/dialogs/fp_conflict_assignment_selector.h | 10 +- eeschema/class_libentry.h | 4 +- eeschema/class_netlist_object.h | 2 +- eeschema/dialog_erc_listbox.h | 4 +- eeschema/dialogs/dialog_annotate.cpp | 6 +- eeschema/dialogs/dialog_bom.cpp | 18 ++-- eeschema/dialogs/dialog_edit_component_in_lib.h | 22 ++-- .../dialogs/dialog_edit_component_in_schematic.cpp | 24 ++--- eeschema/dialogs/dialog_edit_label.cpp | 2 +- .../dialogs/dialog_edit_libentry_fields_in_lib.cpp | 20 ++-- eeschema/dialogs/dialog_edit_one_field.h | 12 +-- eeschema/dialogs/dialog_eeschema_config.cpp | 20 ++-- eeschema/dialogs/dialog_eeschema_options.h | 12 +-- eeschema/dialogs/dialog_erc.h | 14 +-- eeschema/dialogs/dialog_lib_edit_pin.h | 10 +- eeschema/dialogs/dialog_lib_edit_text.h | 4 +- eeschema/dialogs/dialog_lib_new_component.h | 4 +- eeschema/dialogs/dialog_netlist.cpp | 16 +-- eeschema/dialogs/dialog_plot_schematic.h | 10 +- eeschema/dialogs/dialog_print_using_printer.cpp | 22 ++-- eeschema/dialogs/dialog_schematic_find.h | 18 ++-- eeschema/eeschema.cpp | 8 +- eeschema/lib_arc.h | 56 +++++----- eeschema/lib_bezier.h | 42 ++++---- eeschema/lib_circle.h | 54 +++++----- eeschema/lib_collectors.h | 2 +- eeschema/lib_draw_item.h | 2 +- eeschema/lib_field.h | 60 +++++------ eeschema/lib_pin.cpp | 4 +- eeschema/lib_pin.h | 59 +++++----- eeschema/lib_polyline.h | 54 +++++----- eeschema/lib_rectangle.h | 54 +++++----- eeschema/lib_text.h | 58 +++++----- eeschema/libeditframe.h | 24 ++--- eeschema/sch_base_frame.h | 28 ++--- eeschema/sch_bitmap.h | 40 +++---- eeschema/sch_bus_entry.h | 58 +++++----- eeschema/sch_collectors.h | 6 +- eeschema/sch_component.h | 62 +++++------ eeschema/sch_field.h | 44 ++++---- eeschema/sch_junction.h | 50 ++++----- eeschema/sch_line.h | 56 +++++----- eeschema/sch_marker.h | 36 +++---- eeschema/sch_no_connect.h | 52 ++++----- eeschema/sch_sheet.h | 112 +++++++++---------- eeschema/sch_text.h | 98 ++++++++--------- eeschema/schframe.h | 34 +++--- eeschema/viewlib_frame.h | 24 ++--- gerbview/class_gbr_layer_box_selector.h | 11 +- gerbview/class_gbr_layout.h | 2 +- gerbview/class_gbr_screen.h | 2 +- gerbview/class_gerber_draw_item.h | 10 +- gerbview/class_gerbview_layer_widget.h | 10 +- gerbview/dialogs/dialog_print_using_printer.cpp | 12 +-- gerbview/dialogs/dialog_show_page_borders.h | 4 +- .../gerbview_dialog_display_options_frame.cpp | 6 +- gerbview/gerbview.cpp | 8 +- gerbview/gerbview_frame.h | 52 ++++----- gerbview/select_layers_to_pcb.h | 12 +-- include/base_struct.h | 5 +- include/class_base_screen.h | 2 +- include/class_draw_panel_gal.h | 2 +- include/class_pcb_screen.h | 2 +- include/class_sch_screen.h | 2 +- include/class_worksheet_dataitem.h | 2 +- include/dialog_get_component.h | 7 +- include/dialog_helpers.h | 12 +-- include/dialog_hotkeys_editor.h | 8 +- include/dialog_shim.h | 6 +- include/draw_frame.h | 4 +- include/filter_reader.h | 12 +-- include/gal/opengl/noncached_container.h | 2 +- include/geometry/shape_circle.h | 10 +- include/geometry/shape_line_chain.h | 12 +-- include/geometry/shape_rect.h | 10 +- include/geometry/shape_segment.h | 12 +-- include/html_messagebox.h | 2 +- include/kiway.h | 2 +- include/kiway_express.h | 2 +- include/kiway_player.h | 2 +- include/reporter.h | 4 +- include/richio.h | 12 +-- include/tool/context_menu.h | 2 +- include/view/view_group.h | 10 +- include/view/wx_view_controls.h | 8 +- include/worksheet_viewitem.h | 18 +++- include/wxBasePcbFrame.h | 28 ++--- include/wxPcbStruct.h | 46 ++++---- include/wxstruct.h | 6 +- kicad/class_treeprojectfiles.h | 2 +- kicad/dialogs/dialog_template_selector.h | 2 +- kicad/kicad.cpp | 6 +- kicad/kicad.h | 14 +-- kicad/pgm_kicad.h | 6 +- pagelayout_editor/class_pl_editor_layout.h | 2 +- pagelayout_editor/class_pl_editor_screen.h | 2 +- pagelayout_editor/design_tree_frame.h | 2 +- pagelayout_editor/dialogs/dialog_new_dataitem.cpp | 4 +- pagelayout_editor/dialogs/dialogs_for_printing.cpp | 8 +- pagelayout_editor/pl_editor.cpp | 8 +- pagelayout_editor/pl_editor_frame.h | 50 ++++----- pagelayout_editor/pl_editor_undo_redo.cpp | 8 ++ pagelayout_editor/properties_frame.h | 6 +- pcb_calculator/pcb_calculator.cpp | 8 +- pcb_calculator/pcb_calculator.h | 48 ++++----- pcb_calculator/regulators_funct.cpp | 4 +- pcb_calculator/transline/c_microstrip.h | 4 +- pcb_calculator/transline/coax.h | 4 +- pcb_calculator/transline/coplanar.h | 4 +- pcb_calculator/transline/microstrip.h | 4 +- pcb_calculator/transline/rectwaveguide.h | 4 +- pcb_calculator/transline/stripline.h | 4 +- pcb_calculator/transline/twistedpair.h | 4 +- pcbnew/block.cpp | 6 +- pcbnew/class_board.cpp | 4 +- pcbnew/class_board.h | 14 +-- pcbnew/class_board_connected_item.h | 2 +- pcbnew/class_dimension.h | 30 +++--- pcbnew/class_drawsegment.h | 14 +-- pcbnew/class_edge_mod.h | 20 ++-- pcbnew/class_marker_pcb.h | 20 ++-- pcbnew/class_mire.h | 28 ++--- pcbnew/class_module.h | 34 +++--- pcbnew/class_netclass.h | 2 +- pcbnew/class_pad.h | 31 +++--- pcbnew/class_pcb_layer_box_selector.h | 10 +- pcbnew/class_pcb_layer_widget.h | 10 +- pcbnew/class_pcb_text.h | 25 +++-- pcbnew/class_text_mod.h | 22 ++-- pcbnew/class_track.h | 42 ++++---- pcbnew/class_zone.h | 20 ++-- pcbnew/collectors.h | 38 +++---- pcbnew/dialogs/dialog_SVG_print.cpp | 8 +- pcbnew/dialogs/dialog_cleaning_options.h | 4 +- pcbnew/dialogs/dialog_copper_zones.cpp | 16 +-- pcbnew/dialogs/dialog_create_array.h | 18 ++-- pcbnew/dialogs/dialog_design_rules.h | 26 ++--- pcbnew/dialogs/dialog_display_options.h | 4 +- pcbnew/dialogs/dialog_drc.h | 30 +++--- pcbnew/dialogs/dialog_drclistbox.h | 20 ++-- .../dialogs/dialog_edit_module_for_BoardEditor.h | 22 ++-- pcbnew/dialogs/dialog_edit_module_for_Modedit.h | 16 +-- pcbnew/dialogs/dialog_edit_module_text.h | 2 +- pcbnew/dialogs/dialog_find.h | 8 +- pcbnew/dialogs/dialog_footprint_wizard_list.h | 6 +- pcbnew/dialogs/dialog_fp_lib_table.cpp | 42 ++++---- pcbnew/dialogs/dialog_fp_plugin_options.cpp | 20 ++-- pcbnew/dialogs/dialog_freeroute_exchange.h | 12 +-- pcbnew/dialogs/dialog_gendrill.h | 14 +-- pcbnew/dialogs/dialog_general_options.h | 6 +- pcbnew/dialogs/dialog_global_deletion.h | 8 +- .../dialogs/dialog_global_edit_tracks_and_vias.h | 6 +- .../dialog_global_modules_fields_edition.cpp | 4 +- pcbnew/dialogs/dialog_graphic_item_properties.cpp | 4 +- .../dialog_graphic_item_properties_for_Modedit.cpp | 4 +- pcbnew/dialogs/dialog_graphic_items_options.h | 4 +- pcbnew/dialogs/dialog_keepout_area_properties.cpp | 4 +- pcbnew/dialogs/dialog_layers_setup.cpp | 14 +-- pcbnew/dialogs/dialog_modedit_options.cpp | 4 +- pcbnew/dialogs/dialog_move_exact.h | 10 +- pcbnew/dialogs/dialog_netlist.h | 20 ++-- .../dialogs/dialog_non_copper_zones_properties.cpp | 4 +- pcbnew/dialogs/dialog_orient_footprints.cpp | 4 +- pcbnew/dialogs/dialog_pad_properties.cpp | 18 ++-- pcbnew/dialogs/dialog_pcb_text_properties.cpp | 6 +- pcbnew/dialogs/dialog_plot.h | 18 ++-- pcbnew/dialogs/dialog_print_for_modedit.cpp | 10 +- pcbnew/dialogs/dialog_print_using_printer.cpp | 12 +-- pcbnew/dialogs/dialog_set_grid.cpp | 6 +- pcbnew/dialogs/dialog_track_via_size.h | 6 +- pcbnew/dialogs/wizard_add_fplib.h | 24 ++--- pcbnew/dimension.cpp | 4 +- pcbnew/eagle_plugin.h | 14 +-- pcbnew/exporters/gen_modules_placefile.cpp | 8 +- pcbnew/footprint_wizard_frame.h | 28 ++--- pcbnew/github/github_plugin.h | 20 ++-- pcbnew/globaleditpad.cpp | 6 +- pcbnew/gpcb_plugin.h | 14 +-- pcbnew/import_dxf/dialog_dxf_import.h | 6 +- pcbnew/import_dxf/dxf2brd_items.h | 6 +- pcbnew/kicad_plugin.h | 24 ++--- pcbnew/legacy_plugin.h | 14 +-- pcbnew/module_editor_frame.h | 46 ++++---- pcbnew/modview_frame.h | 32 +++--- pcbnew/pcad2kicadpcb_plugin/pcad_plugin.h | 6 +- pcbnew/pcad2kicadpcb_plugin/pcb.h | 12 +-- pcbnew/pcad2kicadpcb_plugin/pcb_arc.h | 4 +- pcbnew/pcad2kicadpcb_plugin/pcb_line.h | 4 +- pcbnew/pcad2kicadpcb_plugin/pcb_module.h | 2 +- pcbnew/pcad2kicadpcb_plugin/pcb_pad.h | 2 +- pcbnew/pcad2kicadpcb_plugin/pcb_pad_shape.h | 2 +- pcbnew/pcad2kicadpcb_plugin/pcb_polygon.h | 4 +- pcbnew/pcad2kicadpcb_plugin/pcb_text.h | 4 +- pcbnew/pcb_painter.h | 4 +- pcbnew/pcbnew.cpp | 8 +- pcbnew/printout_controler.h | 6 +- pcbnew/ratsnest.cpp | 2 +- pcbnew/ratsnest_data.h | 2 +- pcbnew/ratsnest_viewitem.h | 18 +++- pcbnew/router/length_tuner_tool.h | 2 +- pcbnew/router/pns_diff_pair.h | 2 +- pcbnew/router/pns_diff_pair_placer.h | 30 +++--- pcbnew/router/pns_dp_meander_placer.h | 22 ++-- pcbnew/router/pns_joint.h | 2 +- pcbnew/router/pns_line.h | 6 +- pcbnew/router/pns_line_placer.h | 30 +++--- pcbnew/router/pns_meander_placer.h | 12 +-- pcbnew/router/pns_meander_skew_placer.h | 8 +- pcbnew/router/pns_segment.h | 8 +- pcbnew/router/pns_solid.h | 6 +- pcbnew/router/pns_via.h | 6 +- pcbnew/router/router_preview_item.h | 14 ++- pcbnew/router/router_tool.cpp | 2 +- pcbnew/router/router_tool.h | 2 +- pcbnew/sel_layer.cpp | 16 +-- pcbnew/specctra.h | 120 ++++++++++----------- pcbnew/target_edit.cpp | 4 +- pcbnew/tools/bright_box.h | 14 ++- pcbnew/tools/drawing_tool.h | 2 +- pcbnew/tools/edit_points.h | 12 ++- pcbnew/tools/edit_tool.h | 4 +- pcbnew/tools/module_tools.h | 4 +- pcbnew/tools/pcb_editor_control.h | 4 +- pcbnew/tools/pcbnew_control.h | 4 +- pcbnew/tools/placement_tool.h | 4 +- pcbnew/tools/point_editor.h | 4 +- pcbnew/tools/selection_area.h | 16 ++- pcbnew/tools/selection_tool.h | 2 +- pcbnew/xchgmod.cpp | 10 +- polygon/clipper.hpp | 2 +- utils/idftools/dxf2idf.h | 90 ++++++++-------- 247 files changed, 1949 insertions(+), 1866 deletions(-) -- 2.1.4 _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
