On 3/6/2015 5:23 AM, Simon Richter wrote: > Hi, > > On 06.03.2015 06:31, Mark Roszko wrote: > >> I really don't agree with this patch with marking all the subclasses >> as virtual just because if the base class parameters ever change for a >> method the subclasses end up making entirely new functions. And you >> won't get any errors because it'll just call the base method no >> problem. > > Which is not really worse than the current state -- the derived class's > method then becomes a non-virtual member function, and people call the > base version.
In order to prevent this discussion from spiraling out of control yet again, I'm going to leave things the way they are for now. Personally, I have no preference one way or the other. There are sound arguments for both methods. As far as the code is concerned, it really doesn't make much of a difference other than the compiler warnings. Compiler warnings are not a substitute for coding competence. They never have been and they likely never will be. > >> If we did C++11 (which KiCad doesn't because Boost shoots itself in >> the head). Then virtual AND the override keyword make it entirely >> great and safe. > > Yes, that would be great. Incidentally, this is how I verified the > current patch (compiling in C++11 mode with -Wsuggest-override). > > Simon > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
