Le 09/03/2015 17:24, Eldar Khayrullin a écrit : > Add check to negative values of mark length. Use GetCurrentLineWidth() > instead of currentPenWidth. > > 09.03.2015 19:06, jp charras пишет: >> Le 09/03/2015 16:29, Eldar Khayrullin a écrit : >>> It is possible? May be you mean that need check this condition? >>> >>> 09.03.2015 18:19, jp charras пишет: >>>> Le 09/03/2015 15:36, Eldar Khayrullin a écrit : >>>>> I deleted Magic numbers that set parameters of dash lines. Use >>>>> constants >>>>> in mils. Then apply radius correction and scale to plot units when >>>>> start >>>>> to plotting. >>>>> Make for PDF, PS, SVG plotters. >>>>> And some minor fixes. >>>> Thanks. >>>> But what happens when DASH_MARK_LENGTH <= currentPenWidth ? >>>> >>>> >> Because the currentPenWidth can be > DASH_MARK_LENGTH, checking the dash >> mark length always > 0 to avoid issues is certainly good. >> (although this is an unusual pen width value, but who know!) >> >> (and use the virtual GetCurrentLineWidth() instead of currentPenWidth is >> better)
I just committed your patch. I made very minor changes (default values in mm and set to give the same size as dashed lines drawn by wxDC, using short dash style.) Thanks. -- Jean-Pierre CHARRAS _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
