Le 26/03/2015 23:31, Simon Richter a écrit : > On 26.03.2015 12:45, jp charras wrote: > >> I tested your patches, and they add a *very good and very useful >> feature*. I am willing to commit them, but I'll will *very* happy >> if you can fix some (minor) issues: > > I think I've caught most of them. > > Are new features still added to the release? I've conveniently > ignored the release preparations so far, and didn't expect to make > the cut. :) > >> - All dialogs in Kicad have to be internationalized and have a >> RESIZE_BORDER style enabled (an option in wxFormBuilder) > > Done, but the column headers are not translated yet (the column > objects are not yet generated by wxFormBuilder). > >> - Have a look at our coding style policy: class names (and enums) >> are in uppercase letters. > > I think I got it now. I've left the "argument" prefix as "a" > instead of "a_", which is a tiny bit inconsistent, but that's the > way everyone does it, apparently. > > Simon
Thanks. Very good work. I committed it, with a few fixes: make column titles translatable, and derive the dialog from DIALOG_SHIM, which adds some enhancements (for instance retains the dialog size and position during a session. Wish list: - add position of pins - add sorting by pin type (mainly to check is all GND or VCC pins are existing) Again, Thanks. -- Jean-Pierre CHARRAS _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
