Hi Brian, I was about to test it but I didn't since first I was trying to fix here an issue in my branch... I will later do it.
I notice you (people here) start to perform code analysis with some tool (Coverity?) I don't have any experience in using or develop with a code analysis in mind, but I know that when you are developing for code analysis test you have to know in advance what will make is happy, so you do it that way since beginning. One point I notice so far is the variable initialization (and your pointer now). Could someone here perhaps make a small guide to the main aspects to have in mind ? Maybe that could be added to documentation related with coding style and guidelines?.. Thanks in advance! Regards, Mario Luzeiro ________________________________________ From: Kicad-developers [[email protected]] on behalf of Brian Sidebotham [[email protected]] Sent: 13 April 2015 23:00 To: KiCad Developers Subject: Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer I just tested with VRML 1 and VRML 2 and stuff has appeared not to break, so I just committed this change. I opted for the boost::shared_ptr as we're not yet C++11 and there is quite a bit of standard container work going on. Best Regards, Brian. On 11 April 2015 at 00:04, Brian Sidebotham <[email protected]> wrote: > Hi Guys, > > Could someone who has access to both vrml1 and vrml2 models please > test the attached patch which uses a smart pointer rather than > S3D_MESH* to get rid of some coverity issues and feedback whether it > makes your computer explode, or carry on working normally? > > Alternatively, could someone email a couple of vrml files that would > exercise it and I'll put it through it's paces... > > Sorry, there's white space deletions going on in the patch so it's a bit > noisy. > > Thanks, > > Brian. _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
