From other build systems I know something like <pkg>-<version>-<seq>-<name>.patch
So, something like wxWidgets-3.0.2-001-wxDataViewCtrl.patch Do we want to add more patches for open bugs in wxWidgets going forward to the stable release? At least for OS X there is one open issue in 3.0.2 that you cannot open other file formats than KiCad native in pcbnew, because the file type selector is broken. From a customer perspective it would be good, because they just don’t care if the bug is in KiCad or wxWidgets. This will increase maintenance effort, though… Regards, Bernhard > On 15 Jun 2015, at 22:45, Adam Wolf <[email protected]> wrote: > > I'd gladly do *.patch, but not every patch in the patches directory is for > wx, and probably not all of them are for OSX... > > On Jun 15, 2015 3:43 PM, "Nick Østergaard" <[email protected] > <mailto:[email protected]>> wrote: > *.patch ? > > 2015-06-15 22:35 GMT+02:00 Adam Wolf <[email protected] > <mailto:[email protected]>>: > > I will make this update in the builder scripts before tonight's builds. > > > > I wonder if we can set up a filename convention for wx patches so they can > > be automatically applied. Anyone opposed to that idea? I get that we're > > going to be maintaining this out-of-tree for after the stable release, but > > we can probably figure something out... > > > > Adam Wolf > > > > On Mon, Jun 15, 2015 at 3:17 PM, Wayne Stambaugh <[email protected] > > <mailto:[email protected]>> > > wrote: > >> > >> Patch committed in product branch r5755. Thanks Bernhard. > >> > >> I guess our OSX package builder script(s) will need to apply this patch > >> to wxWidgets for our OSX bundles. > >> > >> On 6/14/2015 3:41 PM, Bernhard Stegmaier wrote: > >> > Hi, > >> > > >> > FYI… I guess this is only OS X related. > >> > > >> > Yesterday I wanted to use the Pin Table for the first time and it always > >> > crashes the Library Editor. > >> > After some debugging I am pretty sure that this is a bug in the OS X > >> > implementation of wxDataViewCtrl if using wx[V|H]SCROLL when creating > >> > it. > >> > Did the Pin Table ever work for somebody on OS X (I guess it never did)? > >> > > >> > I already filed a bug report for wxWidgets (still under moderation, so > >> > it doesn’t show up yet). > >> > I don’t know how long this will take, so attached a fix/workaround that > >> > did it for me (for anyone interested, maybe Adam?). > >> > > >> > The only possible workaround in KiCad seems to be to remove the > >> > wxVSCROLL from > >> > > >> > m_Pins = newwxDataViewCtrl( this, wxID_ANY, wxDefaultPosition, > >> > wxSize( -1,-1), > >> > > >> > wxDV_HORIZ_RULES|wxDV_MULTIPLE|wxDV_ROW_LINES|wxDV_VERT_RULES|wxVSCROLL); > >> > > >> > In my tests OS X doesn’t seem to need this (scroll bars are dynamically > >> > shown when needed even without this flag). > >> > But, I don’t know about other platforms and this piece of code probably > >> > can’t be #ifdef’d because this is generated code from wxFormBuilder? > >> > > >> > > >> > Regards, > >> > Bernhard > >> > > >> > > >> > > >> > > >> > > >> > _______________________________________________ > >> > Mailing list: https://launchpad.net/~kicad-developers > >> > <https://launchpad.net/~kicad-developers> > >> > Post to : [email protected] > >> > <mailto:[email protected]> > >> > Unsubscribe : https://launchpad.net/~kicad-developers > >> > <https://launchpad.net/~kicad-developers> > >> > More help : https://help.launchpad.net/ListHelp > >> > <https://help.launchpad.net/ListHelp> > >> > > >> > >> _______________________________________________ > >> Mailing list: https://launchpad.net/~kicad-developers > >> <https://launchpad.net/~kicad-developers> > >> Post to : [email protected] > >> <mailto:[email protected]> > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> <https://launchpad.net/~kicad-developers> > >> More help : https://help.launchpad.net/ListHelp > >> <https://help.launchpad.net/ListHelp> > > > > > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > Post to : [email protected] > > <mailto:[email protected]> > > Unsubscribe : https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > More help : https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp> > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
