Committed in 5794, thanks! Cheers, Orson
On 06/19/2015 06:50 PM, Tomasz Wlostowski wrote: > On 19.06.2015 18:35, jp charras wrote: >> Among issues detected by Coverity, 3 of them worried me. >> (see attached text for these 3 Coverity bugs or strange things) >> >> - In shape_collisions.cpp , CollideShapes compares 4 shapes. >> One case ( SH_RECT / SH_RECT ) is strange, because the actual compaison >> is SH_CIRCLE / SH_RECT. >> >> Is it OK (if yes, a comment should be added), or a bug ? > > A bug, but Rect/Rect test never takes place in the P&S (yet). To be > fixed, but there's no urgency. > >> >> - shape_poly_set.cpp has a bug for me. >> Unless I missed something, a member of a deleted data (.m_next) is used >> in the for loop tests. > > It's a bug, I've attached a patch. Good catch!. > > Cheers, > Tom > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
