The author of this code informed me that there may be some issues if an exception occurs during APP_SINGLE_TOP initialization. I did not confirm this but I suspect that he may be correct. That is why I conditionally compiled them for the time being until it can be confirmed.
On 6/28/2015 4:22 PM, Chris Pavlina wrote: > Hi, > > Just curious here - what was the reason behind the change made in > single_top.cpp in revision 5834? > > http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/revision/5834 > > I had moved Pgm().OnPgmExit() into OnExit() to correct a segfault on > quit - why move it back to OnRun() for non-Python builds? Surely OnExit > is the right place for exit code in all cases? > > -- > Chris > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
