Hi, this fixes a few warnings I get with MSVC, for things that are hopefully obvious as suboptimal. I've left out all the other patches that also resolve warnings in MSVC, but do not immediately smell of a huge problem.
1. We have perfectly fine definitions of PI and PI/2 in math.h 2. If a class is marked for DLL export, all of its superclasses need to be marked for export as well. 3. Assigning 0x80 to a signed char is undefined behaviour, as it relies on a specific behaviour for signed overflow. Behaviour is dependent on how far constant propagation is performed, so might be dependent on optimization level as well. 4. This class has two constructors that can be called with no arguments. Given that they both behave the same, and the second constructor can only be reached by overload resulution if both arguments are given, the default arguments can be dropped. Simon Simon Richter (4): Avoid bringing own definition of M_PI (MSVC warning C4005) Clean up missing DLL export (MSVC warning C4275) Clean up truncation of constants (MSVC warning C4309) Clean up ambiguous default ctor (MSVC warning C4520) gerbview/class_am_param.h | 2 +- include/tool/tool_base.h | 4 +++- include/tool/tool_interactive.h | 2 +- pcbnew/autorouter/autorout.h | 2 +- pcbnew/exporters/export_idf.cpp | 2 +- utils/idftools/idf_common.cpp | 4 ++-- utils/idftools/idf_common.h | 13 +------------ utils/idftools/idf_parser.cpp | 2 +- 8 files changed, 11 insertions(+), 20 deletions(-) -- 2.1.4
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
