Garth, I committed your patch in the product branch r5908. Do you know if there are any bug reports that your patch fixes? I did find this one:
https://bugs.launchpad.net/kicad/+bug/1413549 Python scripting is not directly mentioned in the report but the build info shows wxPython as enabled so it may be related. Thanks, Wayne On 7/8/2015 1:39 PM, Garth Corral wrote: > Yes, it resolves the issue. Thanks, Wayne. > > > Garth > > >> On Jul 8, 2015, at 10:30 AM, Wayne Stambaugh <[email protected] >> <mailto:[email protected]>> wrote: >> >> Garth, >> >> I'm assuming your patch resolves this issue. Please let me know and I >> will try to get your patch committed asap. >> >> Cheers, >> >> Wayne >> >> >> On 7/8/2015 12:14 PM, Garth Corral wrote: >>> Yes, please. Python scripting is completely broken on OS X at the >>> moment. >>> >>> >>> Garth >>> >>> >>>> On Jul 6, 2015, at 8:24 AM, Adam Wolf <[email protected] >>>> <mailto:[email protected]> >>>> <mailto:[email protected]>> wrote: >>>> >>>> Hi folks, >>>> >>>> It would be good if this could get committed to get Python working on >>>> OS X builds again. >>>> >>>> Thanks! >>>> >>>> Adam Wolf >>>> >>>> On Fri, Jul 3, 2015 at 3:54 PM, Garth Corral <[email protected] >>>> <mailto:[email protected]> >>>> <mailto:[email protected]>> wrote: >>>> >>>> The attached patch gets python scripting ‘working’ again on OS X. >>>> Unfortunately, I’m once again seeing the keystroke highjacking >>>> issue that was reported a while back. I’m not sure if it has >>>> regressed at some point while it was not building or it’s a >>>> problem with my builds. I haven’t tested it beyond launching the >>>> console and trying to type. >>>> >>>> >>>> >>>> >>>> >>>>> On Jul 3, 2015, at 7:00 AM, Adam Wolf >>>>> <[email protected] >>>>> <mailto:[email protected]> >>>>> <mailto:[email protected]>> wrote: >>>>> >>>>> Miguel, >>>>> >>>>> They build the python library--I am not sure if it works >>>>> anymore. I think there might have been some regressions--and >>>>> that's part of why I want to switch to scripting by default. >>>>> >>>>> I am trying to make more time to so I can start adding some >>>>> different automated tests to help prevent regressions. >>>>> >>>>> Adam Wolf >>>>> >>>>> On Fri, Jul 3, 2015 at 1:06 AM, Miguel Angel Ajo >>>>> <[email protected] >>>>> <mailto:[email protected]> <mailto:[email protected]>> wrote: >>>>> >>>>> I believe it's a good thing to make scripting widely available. >>>>> >>>>> I need to check the mac scripting builds, do they allow to >>>>> run commandline >>>>> scripts ? (not using the console, I mean). >>>>> >>>>> Adam: thanks for maintaining the OSX side!, >>>>> >>>>> >>>>> Garth Corral wrote: >>>>> >>>>> Hi, Adam. Funny you should ask that now. I just noticed >>>>> that some changes went in recently that completely breaks >>>>> python scripting on OS X. I haven’t had a chance to look >>>>> too deeply at it, but it looks like a check was added on >>>>> the return of wxversion.select(), which was likely always >>>>> failing in the past, but it didn’t matter because >>>>> Bernhard had done all the work in packaging to make sure >>>>> the library paths all worked. Now it fails this check, >>>>> popping up an error dialog which kinda hoses your kicad >>>>> instance at that point. >>>>> >>>>> In general my feeling is that we should just move forward >>>>> with the scripting build, assuming the immediate issues >>>>> are worked out. It is a released feature and the more >>>>> eyes and fingers on it the better, I say. >>>>> >>>>> Garth >>>>> >>>>> On Jul 2, 2015, at 6:30 PM, Adam >>>>> Wolf<[email protected] >>>>> <mailto:[email protected]> >>>>> <mailto:[email protected]>> wrote: >>>>> >>>>> Hi folks, >>>>> >>>>> I currently build both non-scripting and scripting >>>>> Mac nightlies. I am thinking it is time to stop >>>>> building non-scripting and move the scripting builds >>>>> out of DEBUG. They don't work perfectly, but I >>>>> thinking having more folks use them will help expose >>>>> the bugs that do exist. >>>>> >>>>> Thoughts? >>>>> >>>>> Adam Wolf >>>>> Cofounder and Engineer >>>>> W&L >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>> Post to : [email protected] >>>>> <mailto:[email protected]> >>>>> <mailto:[email protected]> >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>> More help : https://help.launchpad.net/ListHelp >>>>> >>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>> Post to : [email protected] >>>>> <mailto:[email protected]> >>>>> <mailto:[email protected]> >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>> More help : https://help.launchpad.net/ListHelp >>>>> >>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>> Post to : [email protected] >>>>> <mailto:[email protected]> >>>>> <mailto:[email protected]> >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>> More help : https://help.launchpad.net/ListHelp >>>> >>>> >>>> >>> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> <mailto:[email protected]> >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> <mailto:[email protected]> >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
