Le 13/08/2015 14:49, Wayne Stambaugh a écrit : > David, > > Please take a look at Lorenzo's comments as well. I believe he is > correct about pulling footprints from the library for exporting. I > missed this when I looked at the patch. You probably do not want to do > this because footprints are stored in the board file and can be modified > in place. This means that its is possible and most likely that > footprint in a board will not be the same as the footprints in the > libraries. > > Thanks, > > Wayne
> > On 8/13/2015 8:45 AM, David Novak wrote: >> Wayne, >> >> Ok. I will work on it and resubmit. >> >> David David, Be aware of the fact patches have to be made against the latest version of Kicad sources. I can be wrong, but I am thinking your patch is against a rather old Pcbnew version (still having 32 layers only, perhaps stable bzr 4022). >> >> >> On 8/12/2015 9:56 AM, Wayne Stambaugh wrote: >>> David, >>> >>> How did you generate your patch file? I doesn't look like a unified >>> diff format to me. The easiest way to generate a unified diff is use >>> Bazaar or git to create a development branch on your system, make your >>> changes, then generate you diff by running bzr diff or git diff. Also, >>> please read the KiCad coding policy, you used tabs instead of spaces for >>> indenting, I see a bunch of trailing white space left behind by your >>> editor, and the preferred maximum line length is 100 characters. >>> >>> Cheers, >>> >>> Wayne >>> >>> >>> On 8/11/2015 9:39 AM, David Novak wrote: >>>> We were required to make the following changes to the GenCAD exporter >>>> after our contract manufacturer rejected the exported GenCAD file. >>>> >>>> * Don't make new shape for every reference designator. Instead, create >>>> shapes based on modules and assign to devices based on reference >>>> designators. >>>> * Don't allow pins without numbers to have duplicate pin numbers. >>>> * Correctly implement MIRRORX. >>>> * Correctly implement flip. >>>> >>>> I've attached the only file that was modified. Additionally, I've >>>> attached a patch file. >>>> >>>> Best Regards, >>>> David -- Jean-Pierre CHARRAS _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
