I committed your patch in the product branch r6125. Thank you for your contribution to KiCad.
Cheers, Wayne On 8/10/2015 4:42 PM, Jon Neal wrote: > Suggestion implemented. New version attached. > > Jon Neal > > On Fri, Aug 7, 2015 at 4:39 AM, Maciej Sumiński <[email protected] > <mailto:[email protected]>> wrote: > > If I may suggest something, how about wrapping the 4 lines to load > preferences into a function (e.g. EDA_DRAW_PANEL::LoadPreferences( const > EDA_DRAW_PANEL* aOther ))? > > Regards, > Orson > > On 08/07/2015 03:01 AM, Jon Neal wrote: > > This patch is to provide a general fix for bug #1468388. There is > a patch > > attached to that bug, but Chris Pavline and I decided that it > doesn't make > > as much sense as this patch. > > > > The other patch adds a center on zoom option to the library editor > > preferences. It would be bad UI to require someone to change the > > preferences for all separate windows with a render. It was also > missing > > three other UI preferences (use middle mouse to pan, limit > panning, and pan > > while moving object). > > > > I implemented this to send over these preferences from eeschema > whenever > > the lib editor or viewer are opened. Same for pcbnew and footprint > > editor/viewer. Not the optimal solution since someone can leave the > > editors/viewers open and change preferences in eeschema/pcbnew so > I added > > FIXME comments. > > > > On a separate and related note, I noticed that the code to open > the library > > viewer: > > > > https://github.com/KiCad/kicad-source-mirror/blob/master/eeschema/sch_base_frame.cpp#L50 > > > > doesn't do the same checks when opening the window as the others > do as seen > > here: > > > > https://github.com/KiCad/kicad-source-mirror/blob/master/eeschema/schframe.cpp#L1120 > > > > Not sure if that check should be added to the library viewer code to > > prevent any issues. Anyone know? > > > > Thanks, > > Jon Neal > > > > > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : [email protected] > <mailto:[email protected]> > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
