This should probably be a wxASSERT rather than a wxFAIL_MSG so in release builds it would not fail. The assertion was put there so that who ever wrote the code that allowed objects that cannot be oriented to be passed to OnOrient would get a reminder of there error. I would prefer that OnOrient not get called for objects that cannot be oriented rather than removing the assert.
On 9/14/2015 10:26 AM, Chris Pavlina wrote: > SCH_EDIT_FRAME::OnOrient uses SCH_COLLECTOR to filter for only orientable > items. The problem is that it only does this for an unselected item. If the > item is returned by SCH_SCREEN::GetCurItem it'll skip that part and go ahead > trying to orient it. Then an assertion failure "Schematic object type %s > cannot be oriented." is tripped. > > The assertion is totally unnecessary; if the object cannot be oriented it > should just silently not be oriented. This patch removes the assertion. > > -- > Chris > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
