FYI Wayne, it looks you caused the doxygen comment for "GetPadCount" to get renamed to "GetUniPadCount" even though the function name stayed the same.
On Wed, Nov 11, 2015 at 1:37 PM, Wayne Stambaugh <[email protected]> wrote: > Damien, > > I committed your patch in the product branch r6308. A few minor > comments on you patch. Your editor left behind some trailing white > space which violates the KiCad coding policy and you forgot to update > the function name in the doxygen comments for GetUniquePinCount(). > Thank you for your contribution to KiCad. > > Cheers, > > Wayne > > On 11/11/2015 7:07 AM, Damien Espitallier wrote: >> Hello, >> >> I made a simple patch for fixing the bug #1300719. The patch implements >> a new function "getUniquePadCount" for a better cvpcb pad count filtering. >> >> >> Diff >> here: >> https://github.com/KiCad/kicad-source-mirror/compare/master...espitall:fix_bug_1300719.diff >> >> >> Regards, >> Damien Espitallier >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp -- Mark _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
