Sounds good to me. I missed that you can only have non-static initializers with a c++11 compiler which caused the build to fail. I attached a patch to fix this.
Jon On Sun, Nov 15, 2015 at 8:32 AM, Wayne Stambaugh <[email protected]> wrote: > On 11/14/2015 4:28 PM, Jon Neal wrote: > > Hi all, > > > > I have two patches right now, one is a little higher priority than the > > other. > > > > The first is eagle_keepout_area_fix.patch. When I "fixed" importing > > polygons in the eagle importer a few months ago I neglected to handle > > keepout areas which causes a segfault if you try to open an eagle board > > with a keepout. This patch fixes this. > > > > The second patch adds the ability to import dimensions from eagle. > > > > Wayne - I'll let you decide whether or not to accept either of these > > patches. I would like to see the first applied for the release since it > > causes a segfault, but the second one could wait until after the release. > > I committed the segfault fix for the stable release in r6313. I will > hang on to the dimension patch until after the stable release since it > is a new feature. If I happen to forget (which is all together possible > given the number of patches I have queued up), please ping me a week or > so after the stable release to remind me. Thanks for the fix. > > Cheers, > > Wayne > > > > > Thanks! > > Jon > > > > > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : [email protected] > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
From d4de15e38f78d74a6f0ba4b7d9948f86fd2ad6e1 Mon Sep 17 00:00:00 2001 From: Jon Neal <[email protected]> Date: Sun, 15 Nov 2015 11:16:58 -0500 Subject: [PATCH] Removed non static initializer since that requires a c++11 compiler. --- pcbnew/eagle_plugin.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pcbnew/eagle_plugin.cpp b/pcbnew/eagle_plugin.cpp index 67db40b..01a3bb2 100644 --- a/pcbnew/eagle_plugin.cpp +++ b/pcbnew/eagle_plugin.cpp @@ -845,7 +845,7 @@ struct EPOLYGON HATCH, CUTOUT, }; - int pour = EPOLYGON::SOLID; + int pour; opt_double isolate; opt_bool orphans; opt_bool thermals; @@ -875,7 +875,8 @@ EPOLYGON::EPOLYGON( CPTREE& aPolygon ) layer = attribs.get<int>( "layer" ); spacing = attribs.get_optional<double>( "spacing" ); isolate = attribs.get_optional<double>( "isolate" ); - + // default pour to solid fill + pour = EPOLYGON::SOLID; opt_string s = attribs.get_optional<string>( "pour" ); if( s ) { -- 2.4.3
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
