Thanks Adam! I'll commit the patch. On 12/7/2015 2:26 PM, Adam Wolf wrote: > I lost the thread, but someone was asking if this works on OS X. It > appears to work fine. > > Adam Wolf > > On Sun, Sep 6, 2015 at 10:48 AM, Simon Richter <[email protected] > <mailto:[email protected]>> wrote: > > Hi, > > this is an improved version of the earlier patch, using the visibility > handling in CMake 3.3, and falling back to changing the global > CXXFLAGS on > previous versions. > > As CMake 3.3 attempts to be compatible with earlier versions, the new > behaviour needs to be explicitly enabled until 3.3 becomes the minimum > supported version, so this is done, and a warning added to remind > whoever > bumps the minimum requirement to remove the compatibility code as well. > > Simon > > --- > CMakeLists.txt | 32 > ++++++++++++++++++++++++-------- > CMakeModules/PerformFeatureChecks.cmake | 2 -- > 2 files changed, 24 insertions(+), 10 deletions(-) > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > <mailto:[email protected]> > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
