Cirilo, I already fixed all of this in my branch before you sent your patch. I just committed the fix for this and gave you credit for the include path fix.
Thanks, Wayne On 12/9/2015 5:33 PM, Cirilo Bernardo wrote: > Yet another patch (removes a CMake warning). I missed one unmatched > if() endif() tag. I opted to remove the tags in the endif() since the > script is short and easy enough to read. > > - Cirilo > > On Thu, Dec 10, 2015 at 7:42 AM, Cirilo Bernardo > <[email protected] <mailto:[email protected]>> wrote: > > Here's an even better patch which incorporates Brano's check on the > return value. > I wasn't checking for "-NOTFOUND". Sorry about the earlier > half-assed patch. > > On Thu, Dec 10, 2015 at 7:28 AM, Cirilo Bernardo > <[email protected] <mailto:[email protected]>> wrote: > > My mistake - it was only concidence that the FindGLM script > worked since the > default search paths happened to have a glm/ directory. > > The attached patch should fix the problem. > > - Cirilo > > > On Thu, Dec 10, 2015 at 12:08 AM, Brano Panak <[email protected] > <mailto:[email protected]>> wrote: > > Hi, > on OSX in CMakeLists.txt > find_package( GLM 0.9.5.4 REQUIRED ) in my setup (osx + > brew) returns incorrect path resulting in compiling error > glm/glm.hpp not found. Include path found is: > /usr/local/include/glm. > Correct should be: /usr/local/include because of includes > from sources are <glm/glm.hpp> > workaround could be changes in source to include <glm.hpp> > or change includes from cmake > > my workaround: > # Find GLM library > find_path(GLM_INCLUDE_DIR "glm/glm.hpp") > if(GLM_INCLUDE_DIR STREQUAL "GLM_INCLUDE_DIR-NOTFOUND") > message(STATUS "glm not found") > else() > message(STATUS "glm include dir: ${GLM_INCLUDE_DIR}") > include_directories("${GLM_INCLUDE_DIR}") > endif() > > however this will not check glm version, could you please > evaluate this workaround? > regards > Brano > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > <mailto:[email protected]> > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > > > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
