Ugh, apparently OSX is "special". Yes, it should work. Trying to get this fixed now, shame I don't have an OSX machine to test on... but at least hopefully have someone on IRC who's working with me.
On Wed, Jan 06, 2016 at 03:18:21PM +0100, Bernhard Stegmaier wrote: > Looks good on OSX. > > Should I be able to edit already? > Didn’t figure out how to do it… pressing a key on a row (as in the old > dialog) just does nothing… > > > Regards, > Bernhard > > > On 06.01.2016, at 05:19, Chris Pavlina <[email protected]> wrote: > > > > Fixed. I didn't realize wxWindow::Layout doesn't necessarily propagate > > to all children on all platforms - had to go through and call it on each > > page of the wxNotebook. > > > > Also caught a second bug: forgot to rebuild the menu bar after the > > hotkeys have been changed. > > > > I've been getting a bit confusing with the patch stack, so I went ahead > > and attached all pending patches directly to this email so you don't > > have to go find the relevant ones. These should apply in order on top of > > the existing head. > > > > I agree with Wayne - any OS X devs who have a chance, can you apply > > these patches and test it out? > > > > > > On Tue, Jan 05, 2016 at 06:54:27PM -0500, Wayne Stambaugh wrote: > >> Take your time. I would rather make sure this is usable before I commit > >> it. It might not be a bad idea to get one of our osx devs to test it > >> just in case there are any oddities on osx waiting to jump up and bite us. > >> > >> Thanks, > >> > >> Wayne > >> > >> On 1/5/2016 6:50 PM, Chris Pavlina wrote: > >>> Whoa, that's interesting. No, there isn't a tab missing (it's supposed > >>> to be on the Controls tab, which is really sparse otherwise), and it > >>> /is/ there - it's just really small. Apparently sizing is broken on > >>> Windows. > >>> > >>> Okay, give me some more time, I'll investigate on Windows. I'll have to > >>> spin up a VM or to for building and testing, might take a day or two > >>> before it's fixed. > >>> > >>> On Tue, Jan 05, 2016 at 06:46:22PM -0500, Wayne Stambaugh wrote: > >>>> Chris, > >>>> > >>>> I tested this patch and something doesn't look write (see attached > >>>> screenshot). Shouldn't there be a fifth tab with the hot keys or is > >>>> there something else going on here? This is a 32-bit build on windows > >>>> 10. I also saw the same thing on my windows 7 box at work. > >>>> > >>>> Wayne > >>>> > >>>> On 1/4/2016 8:35 PM, Chris Pavlina wrote: > >>>>> Third step, again to be merged on top of the previous ones. This one > >>>>> pulls the Hotkeys dialog finally into the eeschema Preferences dialog. > >>>>> To go with it, I also pulled the load/save hotkeys command into that > >>>>> dialog, and for consistency, the load/save preferences command. These > >>>>> are now an "Import/Export..." menu button inside the preferences dialog. > >>>>> > >>>>> Also removed "List Hotkeys", as it's quite redundant - the hotkeys > >>>>> editor lists them just fine. > >>>>> > >>>>> This makes the Preferences menu quite small, and the new Preferences > >>>>> dialog is still nice and neat IMO ^-^ > >>>>> > >>>>> My next step is to investigate the behavior of the Import/Export > >>>>> Preferences command itself. It seems to be a bit buggy. After that I > >>>>> will continue working on the minor GUI quirks I mentioned earlier. > >>>>> > >>>>> > >>>>> On Mon, Jan 04, 2016 at 04:28:20PM -0500, Chris Pavlina wrote: > >>>>>> Second step is to remove the pages from the hotkeys dialog and make it > >>>>>> a > >>>>>> single-page control, so we don't have nested tabs when it's brought > >>>>>> into > >>>>>> the already tabbed options dialog. This patch removes the pages, in > >>>>>> favor of categories in the wxTreeListCtrl. It also makes the final few > >>>>>> steps towards making the HOTKEY_LIST_CTRL fully embeddable. > >>>>>> > >>>>>> This patch applies on top of the previous one. I recommend keeping > >>>>>> them > >>>>>> as separate commits, just in case I've created any bugs (makes them > >>>>>> easier to track down). > >>>>>> > >>>>>> There are a couple known GUI "quirks" - the columns are sized slightly > >>>>>> wrong when there is a vectical scrollbar, and the column sizing > >>>>>> changes > >>>>>> a bit erratically when resizing the dialog. These are wx bugs. I'm > >>>>>> going > >>>>>> to address them after the logical bits are complete. > >>>>>> > >>>>>> On Mon, Jan 04, 2016 at 03:05:33PM -0500, Chris Pavlina wrote: > >>>>>>> Hi, > >>>>>>> > >>>>>>> First step in getting the hotkey configuration inside the main > >>>>>>> preferences dialog is to refactor it a bit. This patch: > >>>>>>> > >>>>>>> - Replaces the wxListCtrl with a wxTreeListCtrl, allowing expandable > >>>>>>> categories in a future change. > >>>>>>> > >>>>>>> - Cleans up the code to make HOTKEY_LIST_CTRL function a bit better > >>>>>>> on > >>>>>>> its own. > >>>>>>> > >>>>>>> - Migrates this dialog as well to TransferData{To,From}Window, use > >>>>>>> matching TransferData{To,From}Control methods on HOTKEY_LIST_CTRL so > >>>>>>> it is easy to embed. > >>>>>>> > >>>>>>> Despite being replaced by a tree-type control, none of the behavior > >>>>>>> has > >>>>>>> been changed yet. The appearance changes slightly due to > >>>>>>> wxTreeListCtrl > >>>>>>> looking a bit different. > >>>>>>> > >>>>>>> -- > >>>>>>> Chris > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> _______________________________________________ > >>>>>>> Mailing list: https://launchpad.net/~kicad-developers > >>>>>>> Post to : [email protected] > >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers > >>>>>>> More help : https://help.launchpad.net/ListHelp > >>>> > >>> > >>> > >>>> _______________________________________________ > >>>> Mailing list: https://launchpad.net/~kicad-developers > >>>> Post to : [email protected] > >>>> Unsubscribe : https://launchpad.net/~kicad-developers > >>>> More help : https://help.launchpad.net/ListHelp > >>> > >> > > <0001-Pull-hotkey-editor-into-eeschema-preferences.patch><0002-Eeschema-options-hotkeys-fixes.patch><0003-Fix-dialog-sizing-issue-on-Windows.patch><0004-Recreate-menu-bar-after-changing-hotkeys.patch>_______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > Post to : [email protected] > > <mailto:[email protected]> > > Unsubscribe : https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > More help : https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp> _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
