Wow, the patch is indeed terribly hard to read. Agreed, though, after rubbing my eyes a lot I don't see anything dangerously different, and I'd like to keep it in sync while we're still keeping a local copy.
Committed in 6456. Thank you. -- Chris On Tue, Jan 12, 2016 at 10:15:13PM +0100, Simon Richter wrote: > Hi, > > this brings our copy of FindwxWidgets.cmake in sync with the version in the > CMake repository. Since last September, CMake includes our changes (version > check, wx 3.1, support for webview component), and these have been released > with CMake 3.4. > > The change to drop the -isystem special handling is taken over with this > patch, so we remain in sync for 3.5. > > When our minimum cmake version reaches 3.4, we can probably drop our own > script and just use the distributed version. > > It would be nice if we could synchronize further changes with CMake > upstream; they seem to be fairly receptive. > > The patch is difficult to read, as the CMake project has different rules on > capitalization and repetition of conditions in else() and endif(). There > is a single functional change dealing with MSVC support on AMD64, > everything else is a no-op for us. > > Simon > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
