Thanks. wxT() used a lot in debugging messages so a debug build will give you better test coverage.
On 2/2/2016 3:01 PM, Chris Pavlina wrote: > I will test this - I'll override wxT() in my local builds and run kicad like > this for a week or so to make sure nothing bad pops up. > > On Tue, Feb 02, 2016 at 02:58:31PM -0500, Wayne Stambaugh wrote: >> On 2/2/2016 11:21 AM, Chris Pavlina wrote: >>> The wx documentation says: >>> >>> "Note that since wxWidgets 2.9.0 you shouldn't use wxT() anymore in your >>> program sources (it was previously required if you wanted to support >>> Unicode)." >>> >>> http://docs.wxwidgets.org/trunk/group__group__funcmacro__string.html >>> >>> *shouldn't* is definitely stronger than "mostly unnecessary", and to me >>> hints >>> that it may be removed at a later date. My guess is that "mostly" is just >>> the >>> usual poor documentation quality in wxwidgets and they weren't being >>> particularly careful with their phrasing... >> >> Which one of these two statements is correct? Do I flip a coin and hope >> for the best? The engineer in me doesn't like guessing. >> >>> >>> Personally I don't like the "remove them as we update the files" approach. >>> We >>> end up in a messy state a year later with half the code one way and half the >>> other, and nobody can remember why. Then they'll remove wxT it and we'll >>> all be >>> scratching our heads wondering if there was some critical reason we left it >>> in >>> for half the cases... >> >> If I wouldn't have seen the "mostly unnecessary" comment then I would >> have been more comfortable with removing them all at once but as it >> stands I would prefer proceed with caution. If we don't see any issues >> after removing wxT() from few files, I would be more comfortable with an >> all inclusive patch. The other option is to test this by modifying the >> wxT definition in wx/chartypes.h to expand to nothing and verifying that >> it does not break anything before generating an all inclusive patch. >> >>> >>> Also - "in the same way that we +forget to+ update the copyright dates", >>> FTFY >>> ;) >>> >>> On Tue, Feb 02, 2016 at 11:10:51AM -0500, Wayne Stambaugh wrote: >>>> Here is the comment in wx/chartypes.h (version 3.0.2) >>>> >>>> /* >>>> wxT ("wx text") macro turns a literal string constant into a wide char >>>> constant. It is mostly unnecessary with wx 2.9 but defined for >>>> compatibility. >>>> */ >>>> >>>> I would have thought that wxT() expands to nothing since 2.9.0 but that >>>> not the case. What makes me nervous is the "mostly unnecessary" >>>> statement. What does "mostly unnecessary" mean? I'm fine with getting >>>> rid of the wxT macros but I'd rather not do it as one huge patch. We >>>> can remove these as we find them in the same way that we update the >>>> copyright dates as we modify the source files. >>>> >>>> On 2/2/2016 10:59 AM, Simon Wells wrote: >>>>> While looking up something in the wxwidgets documentation i noticed >>>>> >>>>> "Note that since wxWidgets 2.9.0 you shouldn't use wxT() anymore in >>>>> your program sources (it was previously required if you wanted to >>>>> support Unicode)." >>>>> >>>>> As kicad only supports wxWidgets 3 is there a plan to change the 4247 >>>>> instances of this in the tree? >>>>> >>>>> thanks >>>>> >>>>> Simon >>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>> Post to : [email protected] >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>> More help : https://help.launchpad.net/ListHelp >>>>> >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> Post to : [email protected] >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
