2016-03-02 19:09 GMT+01:00 Chris Pavlina <pavlina.ch...@gmail.com>: > On Wed, Mar 02, 2016 at 06:31:50PM +0100, Nick Østergaard wrote: >> [snip] >> I guess that is just fine. I have some minor comments on the text inline >> below. >> >> Maybe write Dynamic Librarires? >> Is all this static? If so, maybe state that explicitly too? > > ...why? KiCad is always built the same way wrt. what's dynamic and static, of > what use is that information?
Because I think writing just "Libraries" is not explicit enough. Then it just looks odd that you state the version for wx twice for example. > >> >> [sinp] >> > KiCAD - Compiler: Clang 7.0.2 with C++ ABI 1002 >> >> Maybe we should stick with Kicad or KiCad as we do eveywhere else. > > Yup, we're otherwise consistent about spelling it "KiCad", we should stick to > that. > >> >> > Settings: USE_WX_GRAPHICS_CONTEXT=ON >> > USE_WX_OVERLAY=ON >> > KICAD_SCRIPTING=ON >> > KICAD_SCRIPTING_MODULES=ON >> > KICAD_SCRIPTING_WXPYTHON=ON >> > USE_FP_LIB_TABLE=HARD_CODED_ON >> > BUILD_GITHUB_PLUGIN=ON >> > >> > On Thu, Mar 3, 2016 at 4:52 AM, Simon Wells <swel...@gmail.com> wrote: >> >> Below is the output that is being generated, This does not include the >> >> curl stuff yet (nor does the tree current version info) as i am unsure >> >> of whether curl is currently being used as a dynamic lib or being >> >> statically compiled into kicad, If its that latter then unless we want >> >> to include the curl library in every application in the kicad suite >> >> then only pcbnew's about dialog will be able to have the curl version >> >> info. >> >> >> >> Please comment on the below and advise of any issues you have with the >> >> output and/or layout >> >> >> >> >> >> Application: kicad >> >> Version: (2016-03-01 BZR 6606)-product, release build >> >> Libraries: wxWidgets 3.0.2 >> >> Platform: Mac OS X (Darwin 15.3.0 x86_64), 64 bit, Little endian, wxMac >> >> - Build Info - >> >> wxWidgets: 3.0.2 (debug,UTF-8,STL containers,compatible with 2.8) >> >> Boost: 1.60.0 >> >> KiCAD - Compiler: Clang 7.0.2 with C++ ABI 1002 >> >> Settings: USE_WX_GRAPHICS_CONTEXT=ON >> >> USE_WX_OVERLAY=ON >> >> KICAD_SCRIPTING=ON >> >> KICAD_SCRIPTING_MODULES=ON >> >> KICAD_SCRIPTING_WXPYTHON=ON >> >> USE_FP_LIB_TABLE=HARD_CODED_ON >> >> BUILD_GITHUB_PLUGIN=ON >> >> >> >> On Wed, Mar 2, 2016 at 8:10 AM, Wayne Stambaugh <stambau...@gmail.com> >> >> wrote: >> >>> On 3/1/2016 12:04 PM, Simon Wells wrote: >> >>>> Ah, thats the issue you had with it.... The help menu option has been >> >>>> removed in v2 which i attached a few hours ago. Probably should have >> >>>> made it all a single patch from the start but i didn't for some >> >>>> reason. >> >>>> >> >>>> I will work on adding the ABI information, build time info for wx and >> >>>> the curl info and submit a v3 patch with those included. Should we >> >>>> have build curl information as well or do you think it unnecessary? >> >>> >> >>> I seem to remember that the libcurl build time information does not get >> >>> installed by default by the libcurl build system. It may be that the >> >>> run time information is the best you will be able to do but that's >> >>> better than nothing. If the build time info is ready available, then go >> >>> ahead and include it. >> >>> >> >>>> >> >>>> >> >>>> On Wed, Mar 2, 2016 at 5:39 AM, Wayne Stambaugh <stambau...@gmail.com> >> >>>> wrote: >> >>>>> On 3/1/2016 10:49 AM, Simon Wells wrote: >> >>>>>> Hey Wayne >> >>>>>> >> >>>>>> For what reasons are you not thrilled with putting it in the >> >>>>>> about_dialog? even on linux/windows i can't say i can remember an >> >>>>>> application which has copy version info in the menu structure. >> >>>>>> >> >>>>>> The main reason i reimplemented it in the about dialog class was due >> >>>>>> to wanting/expecting it to be removed from the help menu. The only >> >>>>>> missing information currently i believe is the ABI information which >> >>>>>> can be added easily enough, one of the problems i see with the current >> >>>>>> implementation is its all based on build time information and ignores >> >>>>>> run time (for wx mine does the opposite) i can also easily add the >> >>>>>> curl stuff which i don't believe is in the current implementation. >> >>>>> >> >>>>> If you're going to remove the existing copy version info from the >> >>>>> exiting help menus than I'm OK with adding it to the about dialog. >> >>>>> >> >>>>> Either call EDA_BASE_FRAME::CopyVersionInfoToClipboard() from the about >> >>>>> dialog (I believe all of our top level windows are derived from >> >>>>> EDA_BASE_FRAME), make it static, or move the code to the about dialog >> >>>>> source. Keeping two copies of this around will only create maintenance >> >>>>> headaches. >> >>>>> >> >>>>> If you are going to use the wxWidgets run time information, please >> >>>>> create a new line so we can see the wxWidgets build vs run time info. >> >>>>> It could prove useful. >> >>>>> >> >>>>> Please add the libcurl info. I thought it was already in there. >> >>>>> >> >>>>>> >> >>>>>> thanks >> >>>>>> >> >>>>>> Simon >> >>>>>> >> >>>>>> >> >>>>>> On Wed, Mar 2, 2016 at 4:18 AM, Wayne Stambaugh >> >>>>>> <stambau...@gmail.com> wrote: >> >>>>>>> Simon, >> >>>>>>> >> >>>>>>> I'm not thrilled with adding the copy version info button to the >> >>>>>>> about >> >>>>>>> box. The information you are copying to the clipboard is incomplete >> >>>>>>> and >> >>>>>>> I don't want users the think this is the version information that we >> >>>>>>> want included in bug reports. I don't understand why you wouldn't >> >>>>>>> have >> >>>>>>> just called EDA_BASE_FRAME::CopyVersionInfoToClipboard(). At least >> >>>>>>> it >> >>>>>>> would be the same information. The rest of the changes are fine. >> >>>>>>> >> >>>>>>> Cheers, >> >>>>>>> >> >>>>>>> Wayne >> >>>>>>> >> >>>>>>> On 2/29/2016 1:45 PM, Simon Wells wrote: >> >>>>>>>> Attached is a patch that modifies a few things in the About dialog, >> >>>>>>>> a >> >>>>>>>> screenshot with old and new is also attached >> >>>>>>>> >> >>>>>>>> It removes the horizontal rule which is redundant due to the >> >>>>>>>> auinotebook >> >>>>>>>> Adds Copy Version Info to the about box which i think is a better >> >>>>>>>> place for it than in the help menu esspecially on OSX where about >> >>>>>>>> isn't even in the help menu (I haven't removed the menu items yet >> >>>>>>>> am >> >>>>>>>> interested to hear other peoples thoughts on whether it is used >> >>>>>>>> often >> >>>>>>>> enough to keep it in the main menu bar as well) due to this the code >> >>>>>>>> is currently in 2 places. >> >>>>>>>> I have also changed the about dialog (and version info from the >> >>>>>>>> about >> >>>>>>>> box) change to use the currently running version of wxwidgets rather >> >>>>>>>> than the version that kicad was built with unfortunately this is not >> >>>>>>>> possible with boost >> >>>>>>>> >> >>>>>>>> Simon >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> _______________________________________________ >> >>>>>>>> Mailing list: https://launchpad.net/~kicad-developers >> >>>>>>>> Post to : kicad-developers@lists.launchpad.net >> >>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >> >>>>>>>> More help : https://help.launchpad.net/ListHelp >> >>>>>>>> >> >>>>>>> >> >>>>>>> _______________________________________________ >> >>>>>>> Mailing list: https://launchpad.net/~kicad-developers >> >>>>>>> Post to : kicad-developers@lists.launchpad.net >> >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >> >>>>>>> More help : https://help.launchpad.net/ListHelp >> > >> > _______________________________________________ >> > Mailing list: https://launchpad.net/~kicad-developers >> > Post to : kicad-developers@lists.launchpad.net >> > Unsubscribe : https://launchpad.net/~kicad-developers >> > More help : https://help.launchpad.net/ListHelp >> > >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
