Hi,

just compiled current version and it looks fine to me for OS X.

Rotation of preview is fine.

Zooming is OK, but doesn’t yet respect touchpad-panning setting (always zooms 
on mouse-wheel).
I didn’t test if pinch-to-zoom works.
Auto zoom is pretty decent, so this also can be fixed after merging.

Should panning work in preview (with shift/ctrl-mousewheel)?
It didn’t for me, but I also guess this is simply not needed for preview…

@Cirilo/Mario: 
I can try to look into the touchpad-panning and pinch-to-zoom stuff on the 
weekend, but that shouldn’t block merging it. 
If I remember correctly this is already Marios new code in preview?
Does it make more sense to check (and probably fix/implement in) Marios branch?


Regards,
Bernhard

> On 03.03.2016, at 07:59, Cirilo Bernardo <[email protected]> wrote:
> 
> Hi Wayne,
> 
>  I believe Bernhard has sorted out the OSX issues; others have compiled and 
> installed with Bernhard's changes and haven't had any problems.
> 
>  I haven't had any problems when I installed on MSWin via the installer 
> package which nickoe built on Jenkins. If you're having problems building and 
> installing from source we'd need to have a closer look at the steps you're 
> going through to get kicad up and running.
> 
>  The 3D refactor code was last synced with r6601 but once we sort out the 
> install issues on MSWin it should be trivial to sync.
> 
> - Cirilo
> 
> 
> On Thu, Feb 25, 2016 at 4:51 AM, Wayne Stambaugh <[email protected] 
> <mailto:[email protected]>> wrote:
> Thanks Bernhard,
> 
> Before I committed the 3D refactor, I was going to ask our package devs
> to take a look at it due to the new 3D model plugins.  I would like to
> get this correct before I commit it.  What's the status on windows.
> I've built and installed from source and that works find but I'm
> guessing our installers will need to be changed to accommodate this.
> Once we have the install issues sorted out, I'll commit it.
> 
> Cheers,
> 
> Wayne
> 
> On 2/24/2016 12:26 PM, Bernhard Stegmaier wrote:
> > Hi,
> >
> > I just tried on OS X and plugin handling doesn’t seem to be OK.
> > At least, “make install” does directly (try to) install them to
> > “/Applications/…” which is completely wrong (and also maybe the case why
> > my built binary doesn’t find them?). Also, the path itself under
> > SharedSupport I guess isn’t right.
> >
> > It also install this here
> > bstegmaier$ ls -al /Applications/kicad.app/Contents/Macos/
> > total 464
> > drwxr-xr-x  4 bstegmaier  admin     136 24 Feb 18:17 .
> > drwxr-xr-x  3 bstegmaier  admin     102 24 Feb 18:17 ..
> > -rwxr-xr-x  1 bstegmaier  admin  231560 24 Feb 18:17
> > libkicad_3dsg..0.0.dylib
> > lrwxr-xr-x  1 bstegmaier  admin      24 24 Feb 18:17 libkicad_3dsg.dylib
> > -> libkicad_3dsg..0.0.dylib
> > which doesn’t look right, what is it good for?
> >
> > If you like, I can have a look and try to fix this.
> >
> >
> > Regards,
> > Bernhard
> >
> >> On 23.02.2016, at 22:21, Cirilo Bernardo <[email protected] 
> >> <mailto:[email protected]>
> >> <mailto:[email protected] <mailto:[email protected]>>> 
> >> wrote:
> >>
> >>
> >>
> >> On Tue, Feb 23, 2016 at 7:37 PM, jp charras <[email protected] 
> >> <mailto:[email protected]>
> >> <mailto:[email protected] <mailto:[email protected]>>> wrote:
> >>
> >>     Le 23/02/2016 08:56, Cirilo Bernardo a écrit :
> >>     > On Tue, Feb 23, 2016 at 3:00 AM, Wayne Stambaugh 
> >> <[email protected] <mailto:[email protected]> 
> >> <mailto:[email protected] <mailto:[email protected]>>>
> >>     > wrote:
> >>     >
> >>     >> Cirilo,
> >>     >>
> >>     >> I have one last change request that I missed in my previous review.
> >>     >> Please change your debugging output method.  Windows apps have no
> >>     >> concept of stdout even when run from the command line.  wxLogTrace 
> >> is
> >>     >> the preferred method for debugging output.  It solves two problems. 
> >>  The
> >>     >> debugging strings are redirected to the correct output on all 
> >> supported
> >>     >> platforms and the debugging output is turned off by default.  
> >> Turning on
> >>     >> the debugging output is as simple as:
> >>     >>
> >>     >> export WXTRACE="SOME_DEBUGGING_OUTPUT_TO_ENABLE"
> >>     >>
> >>     >> The is handy so I don't have to sift through everyone's debugging 
> >> output
> >>     >> to find what I'm looking for.  You just need to pick a unique 
> >> string not
> >>     >> used by any other kicad wxLogTrace calls to enable tracing of your
> >>     >> debugging output.
> >>     >>
> >>     >>
> >>     > The 3d_initial_merge branch has been updated to use wxLogTrace;
> >>     > it has also been synchronized to the main branch r6527.  The latest
> >>     > revision for the 3d_initial_merge branch is r6527. The branch builds
> >>     > successfully and I have tested the previewer with various VRML1/2 and
> >>     > X3D models.
> >>     >
> >>     > - Cirilo
> >>
> >>     Thanks, Cirilo.
> >>     Very good work.
> >>
> >>     At least on Windows, 3d_plugin_manager.cpp is missing the line:
> >>     #include <wx/filename.h>
> >>
> >>     Without this include, it does not compile.
> >>
> >>     --
> >>     Jean-Pierre CHARRAS
> >>
> >>     _______________________________________________
> >>     Mailing list: https://launchpad.net/~kicad-developers 
> >> <https://launchpad.net/~kicad-developers>
> >>     Post to     : [email protected] 
> >> <mailto:[email protected]>
> >>     <mailto:[email protected] 
> >> <mailto:[email protected]>>
> >>     Unsubscribe : https://launchpad.net/~kicad-developers 
> >> <https://launchpad.net/~kicad-developers>
> >>     More help   : https://help.launchpad.net/ListHelp 
> >> <https://help.launchpad.net/ListHelp>
> >>
> >>
> >> Thanks Jean-Pierre,
> >>
> >>  I have added the header and checked that it builds on Windows (W7-64
> >> bit).
> >>
> >> - Cirilo
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers 
> >> <https://launchpad.net/~kicad-developers>
> >> Post to     : [email protected] 
> >> <mailto:[email protected]>
> >> <mailto:[email protected] 
> >> <mailto:[email protected]>>
> >> Unsubscribe : https://launchpad.net/~kicad-developers 
> >> <https://launchpad.net/~kicad-developers>
> >> More help   : https://help.launchpad.net/ListHelp 
> >> <https://help.launchpad.net/ListHelp>
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers 
> > <https://launchpad.net/~kicad-developers>
> > Post to     : [email protected] 
> > <mailto:[email protected]>
> > Unsubscribe : https://launchpad.net/~kicad-developers 
> > <https://launchpad.net/~kicad-developers>
> > More help   : https://help.launchpad.net/ListHelp 
> > <https://help.launchpad.net/ListHelp>
> >
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers 
> <https://launchpad.net/~kicad-developers>
> Post to     : [email protected] 
> <mailto:[email protected]>
> Unsubscribe : https://launchpad.net/~kicad-developers 
> <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp 
> <https://help.launchpad.net/ListHelp>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : [email protected]
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Reply via email to