I'm also OK with patch 1. I'm not so sure about patch 2. Do we really need a 1024x1024 icon files or all of the new sizes that were added? I want a monitor where a 1024x1024 icon would be usable. This seems excessive to me. I haven't had time to look at patch 3 yet.
On 3/27/2016 1:42 PM, Chris Pavlina wrote: > I'm fine with patch 1 - I'm going to commit it later today if nobody > complains, > as it does actually fix a few things. > > I don't personally have a problem with patch 2, but I don't want to commit it > without explicit permission as it does do a good bit of rearranging. Thoughts? > > Patch 3 didn't come through for me, does anybody else see the actual patch? > > On Thu, Mar 24, 2016 at 05:24:30PM +0100, Niki Guldbrand wrote: >> Hi All. >> >> I'm submitting these patches for comment, and hopefully inclusion in >> KiCad, these should apply cleanly on master and 4.0. >> >> The reason why I started this work was because in the desktop i >> currently use, all the menu entries all just said "EDA Suite", so >> updated them in the first patch. >> The second patch adds additional mime types, adds an entry for >> pl_editor, rewrote the icon resource script to include additional >> icons, and added a script that installs it all without reinstalling >> KiCad for testing. >> Patch no 3 rearanges all the resources, so the get moved from >> /resources/linux/mime/* to /resources/linux/ >> >> Niki Guldbrand (3): >> Updated the *.desktop files and the pcbnew mime type. >> Update mimetypes, .destop files and resources >> Rearrange the MIME and none MIME files in the linux resources. >> > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
