Thanks for your attention to this, Collin. Another annoyance on OS X, and I'm glad you're looking for solutions to these (like I should have!)
Duane On Thu, May 5, 2016 at 4:48 AM, jp charras <[email protected]> wrote: > Le 05/05/2016 à 10:38, Collin Anderson a écrit : > > Another little OS X fix. Most, though not all, of the dialogs in KiCad > that have cancel buttons > > break copy of text on OS X. If you highlight text (for example, the net > of a pad, an operation I > > find myself doing fairly often) and hit 'Command-C', the dialog is > closed and the text is not > > copied. Command-C is not ever used in this way under OS X, it should > and is always intended to > > copy whatever is selected. > > > > The problem stems from how many of the dialogues in KiCad are declaring > their cancel buttons. If > > one declares a button with this constructor: > > > > wxButton( this, wxID_CANCEL ) > > > > then the default name is filled in, which is "&Cancel". The & is what > makes a button have a > > keyboard shortcut with the directly following letter (C) in windows, but > wx translates this to > > command-<letter> on OS X. This means any button with the name "&C****> > will break copy and paste > > on OS X and simply trigger the button event stead. > > > > I went through and fixed *every single button* in Kicad, such that the > code/behavior is > > completely unchanged on other platforms, but if __APPLE__ is defined, it > will explicitly name the > > button "Cancel" or "Close" as opposed to "&Cancel" or "&Close" (both the > automatic fill-ins if > > not specified). It's not pretty, but the only other option I can see is > remove the keyboard > > shortcut for the cancel and close buttons entirely, or at least change > them to a different > > letter, but that could potentially break other people's workflows. > > > > Here's the patch! > > > Collin, > Thanks for your interest in Kicad. > > I noticed most of patched files are named xxx_base.cpp > > It is clearly written in comments, they are automatically generated (from > corresponding file > xxx_base.fbp). > Therefore patching them is useless, because the next time they are > recreated, the change is lost. > > The patch is not good. Sorry. > > -- > Jean-Pierre CHARRAS > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
