Yes, it should be OK to commit the patch. I apologize for the bug - the function is so short and I still missed checking that.
- Cirilo On Mon, May 30, 2016 at 5:49 PM, jp charras <[email protected]> wrote: > Le 30/05/2016 à 06:23, Cirilo Bernardo a écrit : > > The attached patch *should* fix bug #1585714. > > Although I haven't tested on MSWin, I have checked the > > function which was returning the false negative and > > confirmed that the implementation of the > > wxFileName::GetForbiddenChars() would return the > > path separator and cause the false negative described > > in the bug report. I have opted to simply test the > > validity of the alias component of the name and to > > leave the filesystem to complain about any actual invalid > > filenames. > > > > - Cirilo > > > The patch works for me (Tested on W7). > > Its has a bug, easy to fix: > the line > lpath = aFileName; > should be > wxString lpath = aFileName; > > Can this patch be committed ? > > Thanks. > > > > -- > Jean-Pierre CHARRAS >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
