On 08/12/2016 04:38 PM, Wayne Stambaugh wrote: [snip] >> Hi Orson, >> >> I saw your commit. Thanks for addressing this issue in a timely mannor. >> I have on minor comment. FindFoo.cmake files should always have an >> option to override the default find location which should take >> precedence over the default locations. Typically this is done with an >> environment variable and a definition such as FOO_ROOT. This allows >> developers to use development libraries without having to overwrite >> their system default libraries. I know many of the find modules that >> ship with cmake do not do this. We should not be repeating this bad habit.
Currently there are variables NGSPICE_INCLUDE_PATH and NGSPICE_LIBRARY_PATH serving this purpose. I will have a look how is it done in other modules and try to make it coherent. > Whoops! I forgot to mention, version testing is always a good idea. At > some point it will be an issue and you will have to add support for it. I thought about this, but the information is not stored anywhere in the header file, and the library always gets 0.0.0 number (e.g. libngspice.so.0.0.0), so currently I am out of ideas. Regards, Orson >> Thanks, >> >> Wayne >> >>> >>>> Thanks again everyone for your hard work. >>>> >>>> Cheers, >>>> >>>> Wayne >>> >>> >> >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
