Oops! Good catch. On 8/18/2016 9:35 PM, Simon Wells wrote: > FYI > > /Users/simon/Documents/kicad-app/kicad/eeschema/sch_legacy_plugin.cpp:2171:5: > error: > > void function 'loadHeader' should not return a value [-Wreturn-type] > > wxCHECK( strCompare( "$HEADER", line, &line ), NULL ); > > ^ ~~~~ > > /Users/simon/Documents/kicad-app/wx/build/../bin/include/wx-3.0/wx/debug.h:362:38: > note: > > expanded from macro 'wxCHECK' > > #define wxCHECK(cond, rc) wxCHECK_MSG(cond, rc, (const char*)NULL) > > ^ ~~ > > /Users/simon/Documents/kicad-app/wx/build/../bin/include/wx-3.0/wx/debug.h:359:57: > note: > > expanded from macro 'wxCHECK_MSG' > > #define wxCHECK_MSG(cond, rc, msg) wxCHECK2_MSG(cond, return rc, msg) > > ^ ~~ > > /Users/simon/Documents/kicad-app/wx/build/../bin/include/wx-3.0/wx/debug.h:354:9: > note: > > expanded from macro 'wxCHECK2_MSG' > > op; \ > > ^~ > > /Users/simon/Documents/kicad-app/kicad/eeschema/sch_legacy_plugin.cpp:2612:5: > error: > > non-void function 'loadArc' should return a value [-Wreturn-type] > > wxCHECK_RET( strCompare( "A", line, &line ), "Invalid LIB_ARC definition" > ); > > ^ > > /Users/simon/Documents/kicad-app/wx/build/../bin/include/wx-3.0/wx/debug.h:373:57: > note: > > expanded from macro 'wxCHECK_RET' > > #define wxCHECK_RET(cond, msg) wxCHECK2_MSG(cond, return, msg) > > ^ > > /Users/simon/Documents/kicad-app/kicad/eeschema/sch_legacy_plugin.cpp:2675:5: > error: > > non-void function 'loadCircle' should return a value [-Wreturn-type] > > wxCHECK_RET( strCompare( "C", line, &line ), "Invalid LIB_CIRCLE def... > > ^ > > /Users/simon/Documents/kicad-app/wx/build/../bin/include/wx-3.0/wx/debug.h:373:57: > note: > > expanded from macro 'wxCHECK_RET' > > #define wxCHECK_RET(cond, msg) wxCHECK2_MSG(cond, return, msg) > > ^ > > /Users/simon/Documents/kicad-app/kicad/eeschema/sch_legacy_plugin.cpp:2702:5: > error: > > non-void function 'loadText' should return a value [-Wreturn-type] > > wxCHECK_RET( strCompare( "T", line, &line ), "Invalid LIB_TEXT defin... > > ^ > > /Users/simon/Documents/kicad-app/wx/build/../bin/include/wx-3.0/wx/debug.h:373:57: > note: > > expanded from macro 'wxCHECK_RET' > > #define wxCHECK_RET(cond, msg) wxCHECK2_MSG(cond, return, msg) > > ^ > > /Users/simon/Documents/kicad-app/kicad/eeschema/sch_legacy_plugin.cpp:2802:5: > error: > > non-void function 'loadRectangle' should return a value [-Wreturn-type] > > wxCHECK_RET( strCompare( "S", line, &line ), "Invalid LIB_RECTANGLE ... > > ^ > > /Users/simon/Documents/kicad-app/wx/build/../bin/include/wx-3.0/wx/debug.h:373:57: > note: > > expanded from macro 'wxCHECK_RET' > > #define wxCHECK_RET(cond, msg) wxCHECK2_MSG(cond, return, msg) > > ^ > > /Users/simon/Documents/kicad-app/kicad/eeschema/sch_legacy_plugin.cpp:2834:5: > error: > > non-void function 'loadPin' should return a value [-Wreturn-type] > > wxCHECK_RET( strCompare( "X", line, &line ), "Invalid LIB_PIN definition" > ); > > ^ > > /Users/simon/Documents/kicad-app/wx/build/../bin/include/wx-3.0/wx/debug.h:373:57: > note: > > expanded from macro 'wxCHECK_RET' > > #define wxCHECK_RET(cond, msg) wxCHECK2_MSG(cond, return, msg) > > ^ > > /Users/simon/Documents/kicad-app/kicad/eeschema/sch_legacy_plugin.cpp:3021:5: > error: > > non-void function 'loadPolyLine' should return a value [-Wreturn-type] > > wxCHECK_RET( strCompare( "P", line, &line ), "Invalid LIB_POLYLINE d... > > ^ > > /Users/simon/Documents/kicad-app/wx/build/../bin/include/wx-3.0/wx/debug.h:373:57: > note: > > expanded from macro 'wxCHECK_RET' > > #define wxCHECK_RET(cond, msg) wxCHECK2_MSG(cond, return, msg) > > ^ > > /Users/simon/Documents/kicad-app/kicad/eeschema/sch_legacy_plugin.cpp:3051:5: > error: > > non-void function 'loadBezier' should return a value [-Wreturn-type] > > wxCHECK_RET( strCompare( "B", line, &line ), "Invalid LIB_BEZIER def... > > ^ > > /Users/simon/Documents/kicad-app/wx/build/../bin/include/wx-3.0/wx/debug.h:373:57: > note: > > expanded from macro 'wxCHECK_RET' > > #define wxCHECK_RET(cond, msg) wxCHECK2_MSG(cond, return, msg) > > ^ > > 64 warnings and 8 errors generated. > > > On Fri, Aug 19, 2016 at 12:28 PM, Simon Wells <[email protected]> wrote: >> Hey Wayne, >> >> Will this make it less likely for there to be order changes when you >> save files in future that are currently the bane of those who use VCS >> with kicad projects? >> >> Simon >> >> On Fri, Aug 19, 2016 at 11:33 AM, Wayne Stambaugh <[email protected]> >> wrote: >>> I just committed the component library file parser for the new schematic >>> I/O plugin manager. Please test it when you get a chance. As with the >>> schematic parser and formatter, it requires compiling with >>> -DUSE_SCH_IO_MANAGER=ON. The current library file parser has some odd >>> quirks so there may be some corner cases where older libraries do not >>> load properly. If you get a error loading a library that the current >>> parser loads properly, please send me the library file so I can fix the >>> new parser. As with the schematic parser, the new library parser will >>> be much more strict about the file formatting. There is also a bug in >>> the existing parser where parsed library objects are not sorted at load >>> time. As some point, the sorting must have changed so if you save a >>> library to a new name for round trip testing there will be some minor >>> differences in the order of the draw objects in the component >>> definitions. Next up will be the using the plugin to handle library >>> management which I suspect will be much more likely to break things. >>> >>> Thanks, >>> >>> Wayne >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
