Only one more comment, but a small one so I fixed it for you. I've
attached a fixup diff against yours, please let me know that you are
okay with the changes made to your patch and I'll push it.
1. The phrase "Multiple Layers" must be translateable so that it will
display in the language of the current locale.
2. I bumped the copyright year to 2016 on the files you edited.
Thank you for your contribution!
On Sat, Sep 10, 2016 at 01:51:13PM -0400, Ian Roth wrote:
> Attached is an updated patch. The need for this is that at the place that I
> work, we are to document all board layouts. I use the print function in
> pcbnew, and select 1 layer per page since the documentation is to be in
> black and white. This works great, except that there is no way to flip to a
> page and know what layer you are looking at unless you are already familiar
> with the board. This patch makes looking over the documentation easier
> since the layer name, ie. F.Cu, B.Cu et cetera is printed in the worksheet.
>
> Please feel free to ask any additional questions.
>
> Ian
>
> On Sat, Sep 10, 2016 at 8:15 AM, Chris Pavlina <pavlina.ch...@gmail.com>
> wrote:
>
> > What it says on the tin. It adds a %L format string to labels in the
> > worksheet (title block) that will contain the layer name when printed.
> >
> > I like this, but I agree with Wayne - having to edit so many files
> > because of how the layer name is being passed in is just not good.
> > Having that many function parameters in general can get irritating and
> > confusing.
> >
> > On Sat, Sep 10, 2016 at 02:02:01PM +0200, Nick Østergaard wrote:
> > > I have not tried this patch, but could you be a bit more descriptive of
> > > what this patch do for the user and why?
> > >
> > > Den 08/09/2016 17.09 skrev "Ian Roth" <imr2...@columbia.edu>:
> > >
> > > > This patch allows for printing layer names in pcbnew using a %L
> > formater.
> > > > This is helpful when printing 1 layer per page.
> > > >
> > > > Ian
> > > >
> > > > _______________________________________________
> > > > Mailing list: https://launchpad.net/~kicad-developers
> > > > Post to : kicad-developers@lists.launchpad.net
> > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > > More help : https://help.launchpad.net/ListHelp
> > > >
> > > >
> >
> >
>From 5aefbf74dc39946d37cdd60527dfe6ba264ba790 Mon Sep 17 00:00:00 2001
From: Chris Pavlina <pavlina.ch...@gmail.com>
Date: Sat, 10 Sep 2016 14:08:33 -0400
Subject: [PATCH] fixup! Add %L formatter to worksheets to print layer name.
---
common/worksheet.cpp | 2 +-
gerbview/printout_control.cpp | 2 +-
include/worksheet.h | 2 +-
include/worksheet_shape_builder.h | 2 +-
pcbnew/printout_controler.cpp | 4 ++--
pcbnew/printout_controler.h | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/common/worksheet.cpp b/common/worksheet.cpp
index 45fcac2..367fa98 100644
--- a/common/worksheet.cpp
+++ b/common/worksheet.cpp
@@ -8,7 +8,7 @@
/*
* This program source code file is part of KiCad, a free EDA CAD application.
*
- * Copyright (C) 1992-2013 KiCad Developers, see change_log.txt for contributors.
+ * Copyright (C) 1992-2016 KiCad Developers, see AUTHORS.txt for contributors.
*
*
* This program is free software; you can redistribute it and/or
diff --git a/gerbview/printout_control.cpp b/gerbview/printout_control.cpp
index 74f35aa..cc0da57 100644
--- a/gerbview/printout_control.cpp
+++ b/gerbview/printout_control.cpp
@@ -2,7 +2,7 @@
* This program source code file is part of KiCad, a free EDA CAD application.
*
* Copyright (C) 2014 Jean-Pierre Charras, jp.charras at wanadoo.fr
- * Copyright (C) 1992-2014 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 1992-2016 KiCad Developers, see AUTHORS.txt for contributors.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
diff --git a/include/worksheet.h b/include/worksheet.h
index fbd53cb..cb2a667 100644
--- a/include/worksheet.h
+++ b/include/worksheet.h
@@ -1,7 +1,7 @@
/*
* This program source code file is part of KiCad, a free EDA CAD application.
*
- * Copyright (C) 1992-2014 KiCad Developers, see CHANGELOG.TXT for contributors.
+ * Copyright (C) 1992-2016 KiCad Developers, see AUTHORS.txt for contributors.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
diff --git a/include/worksheet_shape_builder.h b/include/worksheet_shape_builder.h
index bd9af9a..69b2000 100644
--- a/include/worksheet_shape_builder.h
+++ b/include/worksheet_shape_builder.h
@@ -2,7 +2,7 @@
* This program source code file is part of KiCad, a free EDA CAD application.
*
* Copyright (C) 2013-2014 Jean-Pierre Charras, jp.charras at wanadoo.fr
- * Copyright (C) 1992-2014 KiCad Developers, see CHANGELOG.TXT for contributors.
+ * Copyright (C) 1992-2016 KiCad Developers, see AUTHORS.txt for contributors.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
diff --git a/pcbnew/printout_controler.cpp b/pcbnew/printout_controler.cpp
index c7b9775..aec6957 100644
--- a/pcbnew/printout_controler.cpp
+++ b/pcbnew/printout_controler.cpp
@@ -2,7 +2,7 @@
* This program source code file is part of KiCad, a free EDA CAD application.
*
* Copyright (C) 2009 Jean-Pierre Charras, jean-pierre.char...@ujf-grenoble.fr
- * Copyright (C) 1992-2011 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 1992-2016 KiCad Developers, see AUTHORS.txt for contributors.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
@@ -105,7 +105,7 @@ bool BOARD_PRINTOUT_CONTROLLER::OnPrintPage( int aPage )
extractLayer = m_PrintParams.m_PrintMaskLayer.ExtractLayer();
if( extractLayer == UNDEFINED_LAYER )
- layer = "Multiple Layers";
+ layer = _( "Multiple Layers" );
else
layer = LSET::Name( extractLayer );
diff --git a/pcbnew/printout_controler.h b/pcbnew/printout_controler.h
index 90239aa..8527bcf 100644
--- a/pcbnew/printout_controler.h
+++ b/pcbnew/printout_controler.h
@@ -2,7 +2,7 @@
* This program source code file is part of KiCad, a free EDA CAD application.
*
* Copyright (C) 2009 Jean-Pierre Charras, jean-pierre.char...@ujf-grenoble.fr
- * Copyright (C) 1992-2011 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 1992-2016 KiCad Developers, see AUTHORS.txt for contributors.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
--
2.9.3
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
