wxLogError would work too. I want to make sure users are informed when library load errors occur and not pop up an error message for every single library load that fails.
On 9/23/2016 3:26 PM, John Beard wrote: > Hi Wayne, > > Yes, that's a much better idea. The errors can be easily gathered with > wxLogError and are then presented along with any warnings at the end > in a nice interactive way. > > The patch is actually no more complex - I was expecting a string > container to be needed! > > Cheers, > > John > > > On Sat, Sep 24, 2016 at 2:38 AM, Wayne Stambaugh <[email protected]> wrote: >> John, >> >> I would prefer that you always show an error when there is an issue >> loading a library rather than only on debug builds. Please modify your >> patch to collect all load failures and display a message after all of >> the libraries are loaded. This way the user will always see the >> failure(s) and subsequent libraries will still be loaded in case of a >> failure. >> >> Thanks, >> >> Wayne >> >> On 9/23/2016 2:26 PM, John Beard wrote: >>> Hi, >>> >>> If a symbol library in eeschema fails to load when the libs are >>> cached, the IO_ERROR rethrown by that curtails the whole process and >>> subsequent libs don't get cached. This isn't vary fair on poor old >>> Zilog! >>> >>> This patch changes a re-thrown IO_ERROR to a wxASSERT_MSG with the >>> same message, so the user can still see the problem, but can elect to >>> proceed (or break in their debugger) and load the remaining symbol >>> libs. >>> >>> Thanks, >>> >>> John >>> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
