Simon R, I ran into issues applying your patch so I modified the offending section and got it pushed into product master before something else changes. This should contain the bulk of the undefined overrides. I'm fine with a second patch to cover the overrides missed by the patch failure. Thanks, I know this was a rather significant effort.
All developers, Moving forward, I would like us to start using override keyword whenever overriding class members because it's useful information for other devs about which methods are overridden and which methods are not. This is *not* a green light to make every base class member virtual. I expect there to be a one to one relationship where for each virtual base class method there is an overridden method in a derived class. Cheers, Wayne On 9/24/2016 1:10 PM, Simon Wells wrote: > there was some talk on irc from SR about the patch not being complete? > > On Sun, Sep 25, 2016 at 5:59 AM, Michael Steinberg <[email protected]> > wrote: >> Wayne, >> >> maybe it (the "huge" patch) went to your spam folder just as it did for me? >> >> Michael >> >> >> >> Am 24.09.2016 um 18:50 schrieb Wayne Stambaugh: >>> >>> Simon, >>> >>> Are you planning on sending the other half of this fix with the rebased >>> version of your override statement patch? I can already hear the >>> grumbling about the build warnings if I push this patch first. >>> >>> Wayne >>> >>> On 9/23/2016 11:13 PM, Simon Richter wrote: >>>> >>>> --- >>>> CMakeLists.txt | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> Post to : [email protected] >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> More help : https://help.launchpad.net/ListHelp >>>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
