On Sun, Nov 13, 2016 at 12:59:53PM -0500, Wayne Stambaugh wrote: > [snip] > Apparently package devs hate it because they > had remember to set the version and branch strings at config time when > building from source archives otherwise they end up with no-vcs-found > version string. I see Chris added this back into the master branch but > I'm not sure I'm going to keep it. Developers should be using the > version string generated by git and package devs should be using the > version set in KiCadVersion.cmake. I can't see any reason for a third > option.
Apologies, I was under the impression this was still our preferred way to set the build version. Are our intentions for this documented somewhere? > > I will be in an out all day today so if I don't reply I'm not ignoring > you I've just got a full plate today and will respond as soon as I get a > chance. > > Cheers, > > Wayne > > On 11/12/2016 11:55 AM, Nick Østergaard wrote: > > Hi Wayne, > > > > Good news to see a new release, but I wonder about two things: > > > > 1. Boost 1.61 compatibility and bugfix? > > 2. Release version string. > > > > Should the release should include the boost 1.61 fix. It was discussed in: > > [Kicad-developers] About Bug 1604841: Pcbnew crash at moving via, and > > boost::context fixes to make it compatible with boost 1.61 > > > > And there is a patch in [1], although it does not explicitly state > > where it is from, but it looks similar to [2] and [3]. With out the > > patch in [1] I can not build it against boost 1.62 on archlinux. > > > > Secondly, I would like to know how we are supposed to set the release > > infor for the version string. For the 4.0.0--4.0.4 you are supposed to > > use the following options to set the version string: > > > > -DKICAD_REPO_NAME=stable -DKICAD_BUILD_VERSION=4.0.5 > > > > But KICAD_REPO_NAME does not seem to exist anymore... even though I > > set KICAD_BUILD_VERSION it gets overridden by the git info and the > > version string becomes: > > #define KICAD_FULL_VERSION "(2016-11-09 revision 18f77b8)-4.0" > > > > I would have expected to get something like we are used to as, > > "4.0.5-stable" for example. > > > > Nick > > > > [1] > > https://git.archlinux.org/svntogit/community.git/tree/trunk/boost-1.61.patch?h=packages/kicad > > [2] > > https://git.launchpad.net/kicad/commit/?id=06d4894fdbeb00727cdcc667b8899ad73d8eb1c2 > > [3] > > https://git.launchpad.net/kicad/commit/?id=78bc3c65de6c03d19be9902327d08cd4d87c229c > > [4] https://lists.launchpad.net/kicad-developers/msg25556.html > > > > 2016-11-11 23:44 GMT+01:00 Wayne Stambaugh <[email protected]>: > >> This is the last call for patches to the 4 stable branch. If I don't > >> hear anything, I will set version string and tag 4.0.5 in the stable > >> branch on Sunday and give our library, doc, translation, and package > >> devs a couple of weeks to prepare before I make the official announcement. > >> > >> Thanks, > >> > >> Wayne > >> > >> _______________________________________________ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : [email protected] > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
