On 12/7/2016 1:52 PM, Nick Østergaard wrote: > Yes, but lets use the windows use case. A user has 4.0.4 intalled and > have fp-lib-table that matches the one used there for local libs. He > then uninstalls 4.0.4 and install 4.0.5 (this would be the same as an > update with a package manager and possibly osx too), the fp-lib-table > is a user preference and will now reference non existing pretty dirs. > The user starts pcbnew or cvpcb to add parts and when kicad tries to > access one of those libs that do not exist anymore he gets > "unexpected" errors. > > All I ask about is really; what is the desired action? > > I am ok with just including the rename, but I remember that at some > time we said that we should not remove libs for patch releases. This > would require a mention in the release note, which is probably also > acceptable.
I believe keeping the library names the same for stable series releases was what we originally decided. I'm OK with adding a note to the release notes for this one time. In the future, we should probably create a release series branch for the libraries as we did with the source and cherry-pick changes as required. I know it's extra work but this will keep users happy. Hopefully there wont be many more 4 stable releases so it probably doesn't make sense to do this until the 5 stable release. > > > 2016-12-07 19:43 GMT+01:00 Carl Poirier <[email protected]>: >> Well, if I use all the libs as local pretties, using the fp-lib-table that >> has been tagged the same will work, won't it? Do we want to support mix and >> matching tags? >> >> On Wed, Dec 7, 2016 at 10:45 AM, Nick Østergaard <[email protected]> wrote: >>> >>> Well, the issue os the fact that if a user has choosen (one way or the >>> other) to use all of the local libs he needs to update the fp-lib-table >>> manually. An option is to copy the renamed pretty fors to the old name as to >>> not generate errors for the user. >>> >>> >>> Den 07/12/2016 13.21 skrev "Carl Poirier" <[email protected]>: >>> >>> The KIGITHUB variable leads to Github. For using the pretties locally, the >>> fp-lib-table.for-pretty has to be used instead, which is the one that's >>> included by default in the stable release. Anyway, as I had mentioned in >>> another thread very recently, the Github plugin is not even built in the >>> stable release so I don't know how users can get into trouble. >>> >>> Carl >>> >>> On Dec 7, 2016 1:45 AM, "Nick Østergaard" <[email protected]> wrote: >>>> >>>> But this will not help if the user is using them locally. How is that >>>> supposed to be handled? >>>> >>>> 2016-12-07 0:46 GMT+01:00 Carl Poirier <[email protected]>: >>>>> Hi Nick, >>>>> >>>>> I do understand but it is not an issue, Just try it out, go to >>>>> https://github.com/KiCad/Buttons_Switches_ThroughHole.pretty. >>>>> >>>>> Carl >>>>> >>>>> On Tue, Dec 6, 2016 at 5:12 PM, Nick Østergaard <[email protected]> >>>>> wrote: >>>>>> >>>>>> Hi Carl >>>>>> >>>>>> I have found an issue with the lib tagging. I think we decided to not >>>>>> remove any libs for the patch releaes. That is for releases where only >>>>>> the third number changes. What I see is: >>>>>> >>>>>> Buttons_Switches_ThroughHole.pretty remaned to >>>>>> Buttons_Switches_THT.pretty >>>>>> Capacitors_ThroughHole.pretty renamed to Capacitors_THT.pretty >>>>>> Connect.pretty renamed to Connectors.pretty >>>>>> Terminal_Blocks.pretty renamed to Connectors_Terminal_Blocks.pretty >>>>>> Sockets_WAGO734.pretty renamed to Connectors_WAGO.pretty >>>>>> Diodes_ThroughHole.pretty renamed to Diodes_THT.pretty >>>>>> Display.pretty renamed to Displays.pretty >>>>>> Relays_ThroughHole.pretty renamed to Relays_THT.pretty >>>>>> Resistors_ThroughHole.pretty renamed to Resistors_THT.pretty >>>>>> Sockets_BNC.pretty removed? >>>>>> Sockets_Mini-Universal.pretty renamed to >>>>>> Connectors_Mini-Universal.pretty >>>>>> >>>>>> Won't users have to manually update their fp-lib-table? >>>>>> >>>>>> Repos not tagged, Connectors_Amphenol.pretty Battery_Holders.pretty . >>>>>> This looks correct, so that is ok. >>>>>> >>>>>> The fp-lib-table.for-pretty seems to match the repos tagged. >>>>>> >>>>>> Those renamed repos will easily summon errors in the users face. I >>>>>> hope you understand what I mean. >>>>>> >>>>>> 2016-12-03 22:54 GMT+01:00 Carl Poirier <[email protected]>: >>>>>>> I will be tagging the libs in 24h. >>>>>>> >>>>>>> Carl >>>>>>> >>>>>>> On Sat, Dec 3, 2016 at 3:00 PM, Adam Wolf >>>>>>> <[email protected]> >>>>>>> wrote: >>>>>>>> >>>>>>>> I'll take a look early this week! >>>>>>>> >>>>>>>> On Sat, Dec 3, 2016 at 10:09 AM, Wayne Stambaugh >>>>>>>> <[email protected]> >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> Better late than never. I just pushed the 4.0.5 stable release. >>>>>>>>> Just >>>>>>>>> a >>>>>>>>> note to the package devs, you no longer need to set the version >>>>>>>>> string >>>>>>>>> at config. You can use KICAD_VERSION_EXTRA to append any package >>>>>>>>> specific information to the "4.0.5" version string. This will >>>>>>>>> also >>>>>>>>> hold >>>>>>>>> true when building from the source archive when I make the >>>>>>>>> official >>>>>>>>> announcement. Hopefully it wont take more than a week or two to >>>>>>>>> get >>>>>>>>> get >>>>>>>>> documentation, libraries, and most of the packages ready. Please >>>>>>>>> let >>>>>>>>> me >>>>>>>>> know so I can plan the release announcement. Thank you everyone >>>>>>>>> for >>>>>>>>> you >>>>>>>>> efforts. >>>>>>>>> >>>>>>>>> Cheers, >>>>>>>>> >>>>>>>>> Wayne >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>>>>> Post to : [email protected] >>>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>>>>> More help : https://help.launchpad.net/ListHelp >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>>>> Post to : [email protected] >>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>>>> More help : https://help.launchpad.net/ListHelp >>>>>>>> >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>>> Post to : [email protected] >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>>> More help : https://help.launchpad.net/ListHelp >>>>>>> >>>>> >>>>> >>> >>> >> > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
