Diogo, Please pay attention to you code formatting. I saw:
if ( ... ) instead of: if( ... ) more than once in your patch. Thanks, Wayne On 1/31/2017 2:13 PM, Chris Pavlina wrote: > /home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp: In member > function ‘virtual bool DIALOG_EDIT_ONE_FIELD::TransferDataToWindow()’: > /home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp:174:42: > warning: comparison between signed and unsigned integer expressions > [-Wsign-compare] > if ( m_text.find_first_of( '?' ) != -1 ) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ > > wxString::find_first_of returns size_t, so that comparison will always > be false. > > Fix this and I'll merge it - I've been wanting this for a while now :) > > On Tue, Jan 31, 2017 at 06:46:05PM +0000, Diogo Condeço wrote: >> Hi all, >> >> This patch selects the text in the dialog. >> For references the text selected is either the number or the ? (for >> unannotated symbols). >> >> For the other cases the entire text is selected. >> >> This has been tested in windows ( >> http://downloads.kicad-pcb.org/windows/testing/patched/kicad-patched-540-35fc1f3-x86_64.exe) >> and osx. >> A previous version was also tested in linux so it also should be working >> since only the data selection changed. >> >> Thanks >> >> -- >> Diogo Condeço > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
