Chris, I have attached an updated patch that (at least on my end) fixes the unit-deletion bug.
Can you please confirm that you no longer see the erroneous behaviour? I have also included your preselect patch. Cheers, Oliver On Thu, Feb 2, 2017 at 10:33 PM, Chris Pavlina <[email protected]> wrote: > On second thought, I'm reverting it, I found a weird bug. Apologies for > the accidental push, I'll be more careful next time. > > I *was* investigating what I thought was a minor bug (i.e. didn't keep > me from pushing the patch), but I found this. To reproduce: > > 1) Select a single-unit part > 2) Delete one unit of a different, multi-unit part > > The current part gets messed up, like: https://misc.c4757p.com/ > messed-up-part.png > > Not sure if that's a rendering issue or if the pins are actually gone. > > What I *was* looking at is that I thought deleting a unit would just > delete the entire part, and I was going to suggest one of two possible > fixes: > > 1) Modify the component selector to have a mode where it doesn't delete > units > 2) Actually delete the unit, adding code to filter the part and remove > anything on the unit to be deleted and reorder subsequent units. > > I was going to offer to write #2 myself, because that'd be really useful > to me. But you should probably fix the bug described above first and > resubmit. > > ALSO, I was going to contribute a small patch to this to preselect the > current component just like I added to Load Component recently - I > attached a diff for that in case you want it, I had it all done before > noticing this. > > On Thu, Feb 02, 2017 at 06:15:57AM -0500, Chris Pavlina wrote: > > Oops, I didn't mean to push this one at the same time, clumsy push > > command - but it looks good too. I always hated that delete dialog. > > Thank you! > > > > On Thu, Feb 02, 2017 at 09:42:01PM +1100, Oliver Walters wrote: > > > The attached patch removes the clunky "Delete Single Part" dialog in > > > libedit, and re-uses the existing part-selector to find a component to > > > delete. > > > > > > Now, the user can use the filter tool to select a component for > deletion. > > >
lib_deleter_2.patch
Description: Binary data
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
