Hi Nick, Thank you for the patches, I have just pushed them. I squeezed the two patches that rename and regenerate bitmap data, I think they should go together.
Regards, Orson On 02/04/2017 01:10 PM, Nick Østergaard wrote: > I have attached a patch that renames this. It contains three commits > for easier review. > > You should be able to apply with git am rename_pad_settings_tool.patch. > > 2017-01-25 19:13 GMT+01:00 Nick Østergaard <[email protected]>: >> I have always had the feeling that import and export was a bit strange >> user of terminology. I do find it hard to find some better words, but >> what about copy and apply? >> >> Import becomes apply and export becomes copy? >> >> (and then swap the order of them in the list for a more logical ordering) >> >> 2017-01-25 15:35 GMT+01:00 Wayne Stambaugh <[email protected]>: >>> @Orson, would you please take a look at this patch when you get a >>> chance. They both look good to me. >>> >>> I did see a few coding policy issues. Mostly this: >>> >>> + if ( selection[0]->Type() == PCB_PAD_T ) >>> >>> which should be: >>> >>> + if( selection[0]->Type() == PCB_PAD_T ) >>> >>> @John, please clean these up and resubmit the patches when you get a chance. >>> >>> Thanks, >>> >>> Wayne >>> >>> On 1/25/2017 2:39 AM, John Beard wrote: >>>> Sorry, attached the wrong version of the "import export" patch - this >>>> is the correct sequence. >>>> >>>> On Wed, Jan 25, 2017 at 12:41 AM, John Beard <[email protected]> >>>> wrote: >>>>> Hi, >>>>> >>>>> Here are two patches for outstanding GAL functionality: pad >>>>> import/export/push and modedit mirroring. >>>>> >>>>> Pad "push" is what I termed global edit, since I think that describes >>>>> the action of taking a reference and "pushing" it to a filtered subset >>>>> of other pads. I am happy to keep the old name too, if that's >>>>> preferred. >>>>> >>>>> I have implemented in a new PAD_TOOL GAL tool as I think there could >>>>> be more pad-only function in future that can all stick together in >>>>> there. >>>>> >>>>> Let me know if there are any suggestions! >>>>> >>>>> John >>>>> >>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>> Post to : [email protected] >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>> More help : https://help.launchpad.net/ListHelp >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
