Thank you both. I pushed the fixed patch, crediting hauptmech as the original author and leaving Clemens' signoff.
On Mon, Feb 13, 2017 at 10:07:56PM +0100, Clemens Koller wrote: > Well... > > I had a look at this for my very own training pleasure and updated the patch > from Hauptmechto to suit the coding style AFAICT. > (attached) > > Regards, > > Clemens > > On 2017-02-13 21:09, hauptmech wrote: > > Thanks for the heads up Chris. > > > > Respectfully to the developers, I don't have time. If this does not > > match your coding style then consider it bug report. > > > > -Hauptmech > > > > On 14/02/17 04:00, Chris Pavlina wrote: > >> Thank you for your contribution. > >> > >> We're generally pretty strict about the coding style for new code; it > >> can be found at Documentation/development/coding-style-policy.md in the > >> source tree. If you don't see what the problem is, pay particular > >> attention to spacing around parentheses, and to the placement of braces > >> {}. I'd normally just fix this myself on such a small patch, but since > >> Wayne has taken this thread I'll let him wait for you to submit a fixed > >> patch. Just thought I'd explain in a bit more detail. > >> > >> -- Chris > > > > > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp